Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix handling of case-sensitive set loops in RegexPrefixAnalyzer.FindPrefixes #101608

Merged
merged 2 commits into from Apr 29, 2024
Merged

Fix handling of case-sensitive set loops in RegexPrefixAnalyzer.FindPrefixes #101608

merged 2 commits into from Apr 29, 2024

Commits on Apr 26, 2024

  1. Fix handling of case-sensitive set loops in RegexPrefixAnalyzer.FindP… 

    …refixes

For an expression like `[Aa]{2}`, we were generating the strings "AA" and "aa" but not "Aa" or "aA".

This code isn't exercised yet, as we're currently only using FindPrefixes for case-insensitive, but I'm trying to enable it for case-sensitive as well, and hit this. I'm not adding new tests here as plenty of existing tests catch it once it's enabled.
    @stephentoub
    stephentoub committed Apr 26, 2024
    Configuration menu
    Copy the full SHA
    7ee4cbf View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2024

  1. Also exit early as soon as we can detect too many possible prefixes

    @stephentoub
    stephentoub committed Apr 29, 2024
    Configuration menu
    Copy the full SHA
    db16aa9 View commit details
    Browse the repository at this point in the history