Variable misuse ML model found a bug where wrong variable is used to … #23437
Conversation
|
@dotnet/roslyn-analysis @dotnet/roslyn-ide can you take a look? |
|
@jinujoseph is it for master? or should I target it to different branch? |
|
This is for 15.6 preview2 , hence master is correct |
|
cc @Pilchie for ask mode approval |
| @@ -362,7 +362,7 @@ private string GetTestOutputFilePath(string filepath) | |||
|
|
|||
| try | |||
| { | |||
| outputFilePath = Path.GetDirectoryName(_filePath); | |||
| outputFilePath = Path.GetDirectoryName(filepath); | |||
There was a problem hiding this comment.
Can we make this either a static method? Why can't it use the field instead?
There was a problem hiding this comment.
it uses field such as Compilation, so can't be static. I don't know why it accepts filepath rather than not accepting any parameter and use all fields inside. but regardless, getting filepath is not a bug and more flexible if one want to reuse this method for different file path. so I am leaving that as it is.
|
@heejaechang Can you share more info about "variable misuse ML model"? Sounds interesting. |
|
@rchande , i have fwd the mail thread for context |
|
Thanks! |
|
Here's the accepted AI conference paper explaining this new "QA" tool that found this bug. Expect more AI improvements in SW in the future. @Article{ |
…call a method.
Customer scenario
Customer clicks on error list to navigate to an error and VS crash.
Bugs this fixes
#23436
Workarounds, if any
There is no workaround.
Risk
Low risk. the code path is fallback code path, so not always exercised. and it will no longer throw an exception.
Performance impact
N/A
Is this a regression from a previous update?
No
Root cause analysis
when we try to navigate to an error, we try our best to go to right location. since error list can contain staled error, location info can be wrong, so we try to get right snapshot to calculate right location. but it is not always guaranteed that we can get to right text snapshot from roslyn snapshot. when that is failed, we fallback to whatever latest text snapshot we have to calculate location. here code used wrong snapshot when it is supposed to use current snapshot which lead to null ref.
How was the bug found?
Variable misuse ML model tool.