Variable misuse ML model found a bug where wrong variable is used to … (

#23437) * Variable misuse ML model found a bug where wrong variable is used to call a method. * more variable misusage cases
dotnet · Nov 29, 2017 · f212118 · f212118
1 parent 7692269
commit f212118
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 4 deletions.
diff --git a/src/EditorFeatures/TestUtilities/Workspaces/TestHostProject.cs b/src/EditorFeatures/TestUtilities/Workspaces/TestHostProject.cs
@@ -362,7 +362,7 @@ private string GetTestOutputFilePath(string filepath)
 
             try
             {
-                outputFilePath = Path.GetDirectoryName(_filePath);
+                outputFilePath = Path.GetDirectoryName(filepath);
             }
             catch (ArgumentException)
             {

diff --git a/src/VisualStudio/Core/Def/Implementation/TableDataSource/AbstractTableEntriesSnapshot.cs b/src/VisualStudio/Core/Def/Implementation/TableDataSource/AbstractTableEntriesSnapshot.cs
@@ -162,7 +162,7 @@ protected LinePosition GetTrackingLineColumn(Workspace workspace, DocumentId doc
             }
 
             var currentSnapshot = textBuffer.CurrentSnapshot;
-            return GetLinePosition(snapshot, trackingPoint);
+            return GetLinePosition(currentSnapshot, trackingPoint);
         }
 
         private LinePosition GetLinePosition(ITextSnapshot snapshot, ITrackingPoint trackingPoint)

diff --git a/src/Workspaces/Core/Portable/Shared/Extensions/ISymbolExtensions_Accessibility.cs b/src/Workspaces/Core/Portable/Shared/Extensions/ISymbolExtensions_Accessibility.cs
@@ -87,8 +87,6 @@ internal static partial class ISymbolExtensions
             Contract.Requires(within is INamedTypeSymbol || within is IAssemblySymbol);
 
             failedThroughTypeCheck = false;
-            var withinAssembly = (within as IAssemblySymbol) ?? ((INamedTypeSymbol)within).ContainingAssembly;
-
             switch (symbol.Kind)
             {
                 case SymbolKind.Alias: