Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to new apis #1286

Merged
merged 1 commit into from Apr 22, 2021
Merged

update to new apis #1286

merged 1 commit into from Apr 22, 2021

Conversation

brettfo
Copy link
Member

@brettfo brettfo commented Apr 21, 2021

This is a big one.

The VS Code notebook APIs have taken a large change that's mostly incompatible with the current Stable release. Because of that a bunch of common code had to be moved into the stable/src and insiders/src directories and other helpers rearranged as necessary.

These changes aren't meant to be used in Stable currently, only in Insiders so we can unblock our users. The differences between the two will be reconciled before the next Stable release which will then bring both back into close alignment.

There are some bugs yet to be filed against VS Code once this has been merged, specifically:

@colombod
Copy link
Member

microsoft/vscode#121895 was closed and latest insiders addressed the webview ipc issue

@colombod
Copy link
Member

microsoft/vscode#121904 tracks the issue with onDidChangeNotebookAssociation not fired

@colombod colombod self-requested a review April 22, 2021 10:20
Copy link
Member

@colombod colombod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't select cell language with mouse gesture, it flashes only, using the command to select the cell language works and also triggers the onDidChangeNotebookAssociation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extension not working with VS Code insiders 1.56.0 2021-04-22 build
2 participants