Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a big one.
The VS Code notebook APIs have taken a large change that's mostly incompatible with the current Stable release. Because of that a bunch of common code had to be moved into the
stable/src
andinsiders/src
directories and other helpers rearranged as necessary.These changes aren't meant to be used in Stable currently, only in Insiders so we can unblock our users. The differences between the two will be reconciled before the next Stable release which will then bring both back into close alignment.
There are some bugs yet to be filed against VS Code once this has been merged, specifically:
postMessage
calls viaonDidReceiveMessage()
. Because of this bug, JavaScript cells don't behave as expected. (Webview post messages are not posted to the notebook controller microsoft/vscode#121895)onDidChangeNotebookAssociation
should fire even on initial notebook open (onDidChangeNotebookAssociation not fired on initial notebook open microsoft/vscode#121904).