Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview post messages are not posted to the notebook controller #121895

Closed
colombod opened this issue Apr 22, 2021 · 7 comments
Closed

Webview post messages are not posted to the notebook controller #121895

colombod opened this issue Apr 22, 2021 · 7 comments
Assignees

Comments

@colombod
Copy link
Contributor

Version: 1.56.0-insider (user setup)
Commit: 23a2409
Date: 2021-04-21T05:13:42.491Z
Electron: 12.0.4
Chrome: 89.0.4389.114
Node.js: 14.16.0
V8: 8.9.255.24-electron.0
OS: Windows_NT x64 10.0.19042

Steps to Reproduce:

  1. Clone pr update to new apis dotnet/interactive#1286
  2. Go to folder src/dotnet-interactive-vscode/nsiders adn open with VSCode insiders
  3. Launch debugger
  4. set breakpoint in src/dotnet-interactive-vscode/insiders/src/notebookControllers.ts at line 89
  5. Open a .dib or .ipynb notebook

The breakpoint is never hit despite the preloads are posting the messages (the developer tools for the web view will show it in console)

Does this issue occur when all extensions are disabled?: Yes/No

@vscodebot
Copy link

vscodebot bot commented Apr 22, 2021

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@colombod
Copy link
Contributor Author

cc: @brettfo, @jrieken

@jrieken
Copy link
Member

jrieken commented Apr 22, 2021

postMessage should be fixed with 306f32b

@jrieken
Copy link
Member

jrieken commented Apr 22, 2021

related/dupe (?) of #121869

@jrieken jrieken closed this as completed Apr 22, 2021
@colombod
Copy link
Contributor Author

Perfect, when can we test this fix?

@jrieken
Copy link
Member

jrieken commented Apr 22, 2021

Should be in latest insiders

@colombod
Copy link
Contributor Author

Perfect!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants