Fix depends_on in Compose file v3 reference #2278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swarmkit does not seem to have the concept of starting services in a particular order. Tested with docker 1.13.1. Also, `docker-compose bundle` warns us about depends_on being unsupported.
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
compose/compose-file/index.md
Outdated
| A healthcheck indicates you want a dependency to wait | ||
| for another container to be "healthy" (i.e. its healthcheck advertises a | ||
| successful state) before starting. | ||
| > **NOTE:** version 3 no longer supports the `condition` form of `depends_on` |
There was a problem hiding this comment.
@dnephin I think this note can be moved to https://docs.docker.com/compose/compose-file/compose-versioning/#version-3
There was a problem hiding this comment.
I disagree. That section is for fields that have been removed entirely, because there is no where else to document them. In this case the field still exists, but it only supports the "short form". I think users would expect to see this documented in the field section.
|
I just committed a change that combined the 3(!) admonitions into a single one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
includes #2164
Fixes moby/moby#30404 (comment)