Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker swarm does not respect depends_on #2164

Closed
wants to merge 1 commit into from
Closed

Conversation

vHanda
Copy link

@vHanda vHanda commented Mar 7, 2017

Proposed changes

Swarmkit does not seem to have the concept of starting services in a particular order.

Tested with docker 1.13.1. Also, docker-compose bundle warns us about depends_on being unsupported.

It should be obvious from the documentation.

Swarmkit does not seem to have the concept of starting services in a particular order.

Tested with docker 1.13.1. Also, `docker-compose bundle` warns us about depends_on being unsupported.
@mdlinville
Copy link

@aaronlehmann @nishanttotla PTAL

@aaronlehmann
Copy link
Contributor

ping @dnephin

@dnephin
Copy link
Contributor

dnephin commented Mar 10, 2017

The title of this issue is a bit misleading. I believe it should say "Document that docker stack deploy does not support depends_on"

I guess a note here wouldn't hurt.

There's some background in moby/moby#31333. The idea is that on swarm mode services are restarted until they are stable, so the order they are started shouldn't matter. There's also no way to say "has started" because service create is async.

@arvenil
Copy link

arvenil commented Mar 12, 2017

@dnephin

Definitely docs should state Note: These options are ignored when deploying a stack in swarm mode with a (version 3) Compose file.
Also docker stack deploy doesn't say anything that those options are ignored in contrast to raising warning for restart: always.

While it makes sense there is no such concept as deployment order with swarm, availability of those options in doc suggested I could use it to improve starting issues (e.g. some services die because other are not yet available so I get bunch containers that are restarted at initialization couple of times before they finally connect to each other).

Anyway, would be nice to update docs and maybe rise warning for ignored options as I lost plenty of time on this and on moby/moby#30404

@dnephin
Copy link
Contributor

dnephin commented Mar 13, 2017

I've included this fix in #2278 because they are going to conflict.

@mdlinville mdlinville closed this Mar 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants