changes default logging behavior to not tail logs #807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if tail: | ||
| pass | ||
| else: | ||
| break |
There was a problem hiding this comment.
I think this could be simplified to just
if not tail:
return
|
@dnephin thanks for the review. I've made the requested changes. |
|
Cool, lgtm for a major version release |
Signed-off-by: Ben Taitelbaum <ben@coshx.com>
- adds a `--tail` option to `fig logs` - see docker#802 for discussion of `--tail` vs `--no-tail` Signed-off-by: Ben Taitelbaum <ben@coshx.com>
Signed-off-by: Ben Taitelbaum <ben@coshx.com>
|
Thanks for the contribution! Sorry it's taken so long to get a response. I don't think this implementation is correct. It assumes that when the We need to implement this by hitting the logs api endpoint and using the query params to tell it to not tail. There are a few related issues (#1083, #1756) with logs, and I think this will be implemented as part of one of those issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--tailoption tofig logs--tailvs--no-tailSigned-off-by: Ben Taitelbaum ben@coshx.com