Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a --no-tail option to fig logs #802

Closed
wants to merge 1 commit into from
Closed

Conversation

btaitelb
Copy link

@btaitelb btaitelb commented Jan 6, 2015

I'd prefer to have --tail be explicit for fig logs, but this would break backwards compatibility. The motivation behind wanting this is so I can redirect the output of fig logs into a file (e.g. on a CI server where I want the logs as an artifact).

Signed-off-by: Ben Taitelbaum ben@coshx.com

Signed-off-by: Ben Taitelbaum <ben@coshx.com>
@dnephin
Copy link

dnephin commented Jan 6, 2015

I like the idea, I've occasionally wanted to be able to do this as well. I'll try out this branch to see how it works

@btaitelb btaitelb closed this Jan 6, 2015
@btaitelb btaitelb deleted the notail branch January 6, 2015 09:14
@btaitelb btaitelb restored the notail branch January 6, 2015 09:22
@btaitelb
Copy link
Author

btaitelb commented Jan 6, 2015

Didn't mean to close this PR (accidentally deleted the remote branch), so reopening.

@btaitelb btaitelb reopened this Jan 6, 2015
@aanand
Copy link

aanand commented Jan 6, 2015

I would be in favour of making no-tail the default and adding a --tail flag. We can merge it in for the Compose release, which is an opportunity to get breaking changes in.

btaitelb added a commit to btaitelb/compose that referenced this pull request Jan 6, 2015
  - adds a `--tail` option to `fig logs`
  - see docker#802 for discussion of `--tail` vs `--no-tail`

Signed-off-by: Ben Taitelbaum <ben@coshx.com>
@btaitelb
Copy link
Author

btaitelb commented Jan 6, 2015

@aanand I created #807 with the breaking change you're mentioning. I agree that it feels more intuitive (and is a command I tried several times before realizing it didn't exist).

@ataraxer
Copy link

+1 on this one.

btaitelb added a commit to btaitelb/compose that referenced this pull request Mar 30, 2015
  - adds a `--tail` option to `fig logs`
  - see docker#802 for discussion of `--tail` vs `--no-tail`

Signed-off-by: Ben Taitelbaum <ben@coshx.com>
@dnephin
Copy link

dnephin commented May 31, 2015

I believe this was replaced by #807

@dnephin dnephin closed this May 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants