Fix logout in Django 5 with POST action instead of GET #1181
Conversation
helpdesk/urls.py
Outdated
| @@ -215,7 +215,7 @@ def get_context_data(self, **kwargs): | |||
| path( | |||
| "logout/", | |||
| auth_views.LogoutView.as_view( | |||
| template_name="helpdesk/registration/login.html", next_page="../" | |||
| template_name="helpdesk/registration/login.html", next_page=reverse_lazy("helpdesk:home") | |||
There was a problem hiding this comment.
Note that the template_name does not seem to be useful when we provide next_page.
Moreover, there is a template for the confirmation of logging out, but it's not called anywhere. I believe it would make more sense to point to it instead of login page.
There was a problem hiding this comment.
Agreed - go ahead and change the logout next page to the confirmation of logout page.
There was a problem hiding this comment.
Ideally the logged out page needs a link to go back to the login page otherwise the user who is security concious and logs out regularly has to change the URL or use a bookmark.
There was a problem hiding this comment.
Alright, here's what I have now for the logged_out page :
What do you think?
A login button is available in the header so it might not be needed to show it again.
|
Awesome - much better flow |
Fixes #1174
Uses technique from https://learndjango.com/tutorials/django-login-and-logout-tutorial#log-out-button