Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for my-tickets view and public ticket view #1147

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

timthelion
Copy link
Collaborator

We didn't set the secret key in the urls in the my_tickets view so it wasn't possible to actually comment on tickets visited from this view.

@timthelion
Copy link
Collaborator Author

You have to merge the other two PRs I submitted before this one...

@tecbr
Copy link
Contributor

tecbr commented Dec 4, 2023

Translation fixes in my_tickets.html:

                <th>Title</th>
                <th>Queue</th>
                <th>Status</th>
                <th>Created</th>
                <th>Due Date</th>
                <th>Submitter</th>

->

                <th>{% trans "Title" %}</th>
                <th>{% trans "Queue" %}</th>
                <th>{% trans "Status" %}</th>
                <th>{% trans "Created" %}</th>
                <th>{% trans "Due Date" %}</th>
                <th>{% trans "Submitter" %}</th>

@timthelion
Copy link
Collaborator Author

@tecbr Fixed I hope.

Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - looks good

@uhurusurfa
Copy link
Collaborator

@timthelion - if you want to release the webhooks enhancement and the my tickets bugfix asa new release then please raise a PR with the the "version" parameter changed to 1.2.0 in setup.py

@uhurusurfa uhurusurfa merged commit 8265380 into django-helpdesk:main Dec 6, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants