Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webhooks #1146

Merged
merged 5 commits into from
Dec 5, 2023
Merged

Webhooks #1146

merged 5 commits into from
Dec 5, 2023

Conversation

timthelion
Copy link
Collaborator

This PR implements the ability to add webhooks which get notified when tickets are created and followups are added. I am implementing this for a client who needs to create bots that can automatically interact with the helpdesk. #1145 needs to be merged before this one as the two PRs build on each-other.

@timthelion timthelion changed the title Webhooks 2 Webhooks Dec 3, 2023
Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.
Just some minor suggestions around the documentation and handling the split of URL's.

If possible, it wouyld be good if there was a test that verified it works for multiple URL's for a new or followup ticket.

helpdesk/settings.py Outdated Show resolved Hide resolved
docs/webhooks.rst Show resolved Hide resolved
docs/webhooks.rst Outdated Show resolved Hide resolved
@timthelion
Copy link
Collaborator Author

Thank you for the thorough review. Updated.

Copy link
Member

@Benbb96 Benbb96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good me too.
Good job, and also well done for the triage of issues 🙂

Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎸

@uhurusurfa uhurusurfa merged commit c138047 into django-helpdesk:main Dec 5, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants