-
Notifications
You must be signed in to change notification settings - Fork 633
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webhooks #1146
Webhooks #1146
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
Just some minor suggestions around the documentation and handling the split of URL's.
If possible, it wouyld be good if there was a test that verified it works for multiple URL's for a new or followup ticket.
Thank you for the thorough review. Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good me too.
Good job, and also well done for the triage of issues 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎸
This PR implements the ability to add webhooks which get notified when tickets are created and followups are added. I am implementing this for a client who needs to create bots that can automatically interact with the helpdesk. #1145 needs to be merged before this one as the two PRs build on each-other.