Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my tickets view for logged in non-staff users #1143

Merged
merged 11 commits into from
Nov 27, 2023

Conversation

timthelion
Copy link
Collaborator

image

This includes a breaking change as I forced pagination on the API.

Implements: #323

I also ended up switching to class based views for the public views.

Note: This is a breaking change as it forces pagination on the API endoints.
This should have been done from the start as the API without pagination is
useless when there are large numbers of tickets.
Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me - giv en there are no unit tests to verify the functionality does what it should I will have to find time toi manually test this ... hopefully on the weekend.

@timthelion
Copy link
Collaborator Author

I added unit tests for the API endpoint ;)

Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as described - just the one consideration noted.

Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 - works as expected. Nice job.

@uhurusurfa uhurusurfa merged commit 6f1749a into django-helpdesk:main Nov 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants