New Checklist feature #1090
New Checklist feature #1090
Conversation
…m in order to better generate new task row dynamically
|
I've recorded a video of me testing what I have implemented for checklists. I believe it's easier to see it instead of too much screenshots. But I'm thinking of deploying a demo site (with Render or PythonAnywhere) in order to better test features. I'm willing to write more test but I'm looking forward for your feedback 😃 |
|
There is always more one can do around unit tests but it looks like you have the key stuff covered. |
|
Thank you @uhurusurfa ! Yes I think I'm done with the tests, they should cover the main part of added code. I can now work on a different PR in order to add documentation about this new feature. While coding it, I noticed a lot of pages that need reformatting, or some views that need to be refactored. I may also work on this if I get time 🙂 |
|
I agree. Fantastic job @Benbb96. The videos look great. I will take a
better look over the next few days. But it seems to look good so far in
meeting the brief.
…On Wed, 3 May 2023, 5:15 pm Christopher Broderick, ***@***.***> wrote:
There is always more one can do around unit tests but it looks like you
have the key stuff covered.
We can add more if and when issues arise to cover anything that may have
been missed.
@brucegibbins <https://github.com/brucegibbins> - how does this look to
you as a first step? More functionality can be added in separate PR's as
needed.
—
Reply to this email directly, view it on GitHub
<#1090 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEAXOGCTNCZ7HNPF57Z2ICLXEIAXZANCNFSM6AAAAAAXQS2GG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I have deployed your feature to our production instance. Does the job.
Thanks again.
…On Wed, 3 May 2023, 5:46 pm Benbb96, ***@***.***> wrote:
Thank you @uhurusurfa <https://github.com/uhurusurfa> ! Yes I think I'm
done with the tests, they should cover the main part of added code. I can
now work on a different PR in order to add documentation about this new
feature.
While coding it, I noticed a lot of pages that need reformatting, or some
views that need to be refactored. I may also work on this if I get time 🙂
—
Reply to this email directly, view it on GitHub
<#1090 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEAXOGGQUCSF4TRIH7TLUU3XEIEOFANCNFSM6AAAAAAXQS2GG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Glad to read that! Don't hesitate if you see some bugs or potential improvements 😉 |
|
Thanks. The drag and mive is a nice feature in the task list.
I must admit to not being a big fan of the larger than life buttons that
the whole helpdesk package uses and some of the padding and alignment
around them. Just seems to be a lot of white space and gaps around things.
Not your solution specifically but just around the content in general. The
ticket list and view forms in particular.
Its one of the areas I'd like to improve but I'm not much of a front end ui
coder. But it is on my radar.
Again. Thanks for your help
…On Thu, 4 May 2023, 10:38 pm Benbb96, ***@***.***> wrote:
Glad to read that! Don't hesitate if you see some bugs or potential
improvements 😉
—
Reply to this email directly, view it on GitHub
<#1090 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEAXOGDNZ6DWKMLPYF3AWCTXEOPKTANCNFSM6AAAAAAXQS2GG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yes, I see your point, and part of it comes from the Bootstrap Framework. But I agree, there are a lot of improvements in terms of UI Design. I think I can help with that too! We should create issues with screenshots of what could be fixed in order to track all these enhancements 🙂 |
|
I'm up for that as well. Although I'm not much of a front end web
developer. I guess we raise a separate Issue and then go from there? I did
try to put some front end changes in play in my original fork but ended up
reversing them out as it broke some other things. One thing I would like to
do is simplify the header area of the ticket View. IMHO it is too bulky
with a big heavy table upfront with too much padding and I spend a stack of
time scrolling past it.
My initial changes were to basically have foldable sections but I must have
mashed up a </div> as it ended up breaking and again to be honest the HTML
in that page is quite dense and not easily manipulated. Again, just my
opinion.
cheers
…On Fri, 5 May 2023 at 17:42, Benbb96 ***@***.***> wrote:
Yes, I see your point, and part of it comes from the Bootstrap Framework.
But I agree, there are a lot of improvements in terms of UI Design.
I think I can help with that too! We should create issues with screenshots
of what could be fixed in order to track all these enhancements 🙂
—
Reply to this email directly, view it on GitHub
<#1090 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEAXOGETLL2WW6FDJM6NIRDXESVMVANCNFSM6AAAAAAXQS2GG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I agree with you on that point too. Having collapsible panels could be a solution, or maybe tabs. I'll create an issue for this 😉 |
Fixes #1087