Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 2 dependency and Add Script for Pypi release #1081

Merged
merged 7 commits into from
Apr 13, 2023

Conversation

uhurusurfa
Copy link
Collaborator

Support for deplying a release tag to PyPi automatically
REove the six package and the code that used it to maintain Python 2 compqtibility

@martin-marty
Copy link
Collaborator

Is there no Private PyPi configuration for local testing before pushing?

@uhurusurfa
Copy link
Collaborator Author

Is there no Private PyPi configuration for local testing before pushing?

If you have one you have access please feel free to try it out.

@martin-marty
Copy link
Collaborator

How urgent is this please @uhurusurfa ? I've very little time available at the moment, if it's a high priority, I can at the very least create a check list of todo's in order to implement this. If you can wait until the weekend, I can try to find the time to implement what's required in order to cover this.

@uhurusurfa
Copy link
Collaborator Author

How urgent is this please @uhurusurfa ? I've very little time available at the moment, if it's a high priority, I can at the very least create a check list of todo's in order to implement this. If you can wait until the weekend, I can try to find the time to implement what's required in order to cover this.

@martin-marty - I have no vested interest in checking it on a separate repository as the effort just doesnot warrant it in my opinion but if you want to invest your time in it please go ahead. If it does not work then there is no issue. If it does the wrong thing there is always the manual process to unwind it quickly and/or publish it correctly.

@martin-marty
Copy link
Collaborator

Good morning @uhurusurfa - I've ran into issues with private-pypi so haven't been able to implement a local pypi server (there's a dependency issue :

$ pip install redis-server
ERROR: Could not find a version that satisfies the requirement redis-server (from versions: none)
ERROR: No matching distribution found for redis-server

).
It looks good though apart from helpdesk.views.staff is missing a time import, it's used in views.staff.get_due_date_from_request_or_ticket.
I don't have write permission for this branch but it can be fixed by changing line 13:
from datetime import datetime, timedelta -> from datetime import datetime, time, timedelta

Christopher Broderick added 2 commits April 3, 2023 10:49
@uhurusurfa
Copy link
Collaborator Author

Thanks @martin-marty - good catch.
Can you review and approve the PR please?

Copy link
Collaborator

@martin-marty martin-marty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, approved as requested.

Copy link
Collaborator

@martin-marty martin-marty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

Copy link
Collaborator

@martin-marty martin-marty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, I don't have write access though...

@uhurusurfa uhurusurfa merged commit 26628db into main Apr 13, 2023
6 checks passed
@uhurusurfa uhurusurfa deleted the pypi_release branch April 13, 2023 22:39
@uhurusurfa uhurusurfa restored the pypi_release branch April 16, 2023 13:32
@uhurusurfa uhurusurfa deleted the pypi_release branch April 16, 2023 13:34
@gwasser gwasser added this to the 0.5.0 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants