Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1075 - make view agnostic to format of incoming due date #1076

Merged
merged 2 commits into from
Mar 26, 2023
Merged

#1075 - make view agnostic to format of incoming due date #1076

merged 2 commits into from
Mar 26, 2023

Conversation

finnertysea
Copy link
Contributor

Fix for #1075

uhurusurfa
uhurusurfa reviewed Mar 18, 2023
View reviewed changes
Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clearly we are missing a unit test that catches this.
Can you add one?

uhurusurfa
uhurusurfa approved these changes Mar 26, 2023
View reviewed changes
Copy link
Collaborator

@uhurusurfa uhurusurfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - thanks for the fix. Will look at making a unit test in a separate PR

@uhurusurfa uhurusurfa merged commit 747b651 into django-helpdesk:main Mar 26, 2023
6 checks passed
@gwasser gwasser added this to the 0.5.0 milestone Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uhurusurfa uhurusurfa uhurusurfa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@finnertysea @uhurusurfa @gwasser