-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note to docs for preload #1033
Open
jsumnerPhD
wants to merge
7
commits into
django-compressor:develop
Choose a base branch
from
jsumnerPhD:develop
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
28ac416
Add support for rel=preload
jsumnerPhD dba2466
Fix #931 and #926 at the same time
jsumnerPhD 60b1ef8
Merge pull request #1 from django-compressor/develop
jsumnerPhD 345ee58
Merge
jsumnerPhD cd7898f
Fix merge
jsumnerPhD 1b1ee8d
Add a formatted note to usage info for preload
jsumnerPhD e35713a
Mix mode into offline manifest hash key to fix bug in preload
jsumnerPhD File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps "load the file via a
compress
block with identical contents" (not sure if that's correct, but in any case some info about how the block should look like would be nice)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. And I am realizing that we should probably also clarify that it needs the same block name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, what do you mean by "same block name"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
django-compressor supports setting a block name that will be prepended to the file name for a compressed resource. The block name used must be the same between the preload block and the subsequent file block for the file names to match.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I'll try that since I still have the error with offline compression at runtime:
compressor.exceptions.OfflineGenerationError: You have offline compression enabled but key "d194e833cc7675b07be5a9dee9eea326d443e6f691265734b1b3abeb2b7982be" is missing from offline manifest. You may need to run "python manage.py compress". Here is the original content
We have identical couples of compress tags (preload + non-preload) in several templates, maybe that's the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... that error may be something different. Possibly related to #961 ? The last commit above (e35713a) was a quick and dirty attempt to solve that issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what I thought and why I tried your PR. Maybe It is a corner case with inheritance and block tag inside compress tags.
I just jumped in the project for a technical migration and found the offline compression appealing.
Anyway, I'll stick to the online compression for now, many thanks for your time.