Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note to docs for preload #1033

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

jsumnerPhD
Copy link
Contributor

A small step in addressing #1032 . (I'd just cherry-pick 1b1ee8d.)

.. note::

This operation only generates the preload HTML link element with the correct filename hash.
You must subsequently load the file within a ``compress`` block to use the associated resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps "load the file via a compress block with identical contents" (not sure if that's correct, but in any case some info about how the block should look like would be nice)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. And I am realizing that we should probably also clarify that it needs the same block name.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, what do you mean by "same block name"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

django-compressor supports setting a block name that will be prepended to the file name for a compressed resource. The block name used must be the same between the preload block and the subsequent file block for the file names to match.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll try that since I still have the error with offline compression at runtime:
compressor.exceptions.OfflineGenerationError: You have offline compression enabled but key "d194e833cc7675b07be5a9dee9eea326d443e6f691265734b1b3abeb2b7982be" is missing from offline manifest. You may need to run "python manage.py compress". Here is the original content

We have identical couples of compress tags (preload + non-preload) in several templates, maybe that's the issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... that error may be something different. Possibly related to #961 ? The last commit above (e35713a) was a quick and dirty attempt to solve that issue.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought and why I tried your PR. Maybe It is a corner case with inheritance and block tag inside compress tags.
I just jumped in the project for a technical migration and found the offline compression appealing.
Anyway, I'll stick to the online compression for now, many thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants