Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support voiceChannelEffectSend event #9308

Open
wants to merge 5 commits into
base: v13
Choose a base branch
from

Conversation

jaw0r3k
Copy link
Contributor

@jaw0r3k jaw0r3k commented Apr 1, 2023

Please describe the changes this PR makes and why it should be merged:

🤖 Generated by Copilot at 0c36226

Summary

🎙️🎭🚀

This pull request adds a new feature to the discord.js library that allows listening for voice channel effects, such as emoji reactions, sent by users. It defines a new event, a new structure, a new action, and a new handler for the feature. It also updates the Constants.js, ActionsManager.js, and index.js files to support the feature.

Sing, O Muse, of the cunning coder who devised
A new action for the discordant gateway, and thus
Enabled the voice channel effect, a wondrous sight
Like the flashing thunderbolts of Zeus the cloud-gatherer.

Walkthrough

  • Register a new action class for handling voice channel effect send events (link)
  • Define the VoiceChannelEffectSendAction class that emits a voiceChannelEffectSend event on the client with a new VoiceChannelEffect structure (link)
  • Add a new handler function for the VOICE_CHANNEL_EFFECT_SEND opcode from the gateway (link, link)
  • Define the VoiceChannelEffect class that represents an effect used in a voice channel, such as an emoji reaction (link, link)
  • Add a new event name, documentation, and parameter type for the voiceChannelEffectSend event to the Constants.js file (link, link, link)
  • Define the possible animation types of the voice channel effect using the createEnum function (link, link)

Status and versioning classification:

  • I know how to update typings and have done so
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Apr 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Apr 2, 2023 1:24pm

@vercel
Copy link

vercel bot commented Apr 1, 2023

@jaw0r3k is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

get channel() {
return this.guild.channels.cache.get(this.channelId) ?? null;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User getter See 9228 (comment)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized this doesn't extend Base, would that be possible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized this doesn't extend Base, would that be possible?

Idk structure was copied from jiralite pr lol

Copy link
Contributor Author

@jaw0r3k jaw0r3k Apr 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About user getter i wasnt sure
its a guild object so like e.g. voice state it doesnt have user

src/util/Constants.js Outdated Show resolved Hide resolved
Co-authored-by: Tetie <tjvssr@gmail.com>
@Jiralite Jiralite added this to the discord.js 13.18 milestone May 14, 2023
aiko-chan-ai added a commit to aiko-chan-ai/discord.js-selfbot-v13 that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

None yet

4 participants