New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Voice Channel Send Effects #9288
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-jiralite-feat-voice-effects-discordjs.vercel.app/ |
may you add channel getter? |
ac225c2
to
4a1e935
Compare
also shouldn't it be an action, which handlers just handle |
packages/discord.js/src/client/websocket/handlers/VOICE_CHANNEL_EFFECT_SEND.js
Show resolved
Hide resolved
/** | ||
* Represents an effect used in a {@link VoiceChannel}. | ||
*/ | ||
class VoiceChannelEffect { |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. Extending Base
would mean this would (not publically) add _clone()
, _patch()
, and _update()
to the class which are all irrelevant methods. In addition, valueOf()
for this structure would return undefined
as there is no id
sent in voice channel effects.
This seems to already be done. |
discord.js/packages/discord.js/src/client/actions/Action.js Lines 5 to 15 in b27c1d0
My take on this is until there are any REST events that affect this event or we need to manually call this code, there is no need to add it. It is a very simple structure: receive a WebSocket event then emit it. Also, not every event has an action. So no, it shouldn't be an action. |
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: