Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: slashcommand builder type split #10253

Merged
merged 1 commit into from May 5, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented May 5, 2024

Please describe the changes this PR makes and why it should be merged:

SlashCommandBuilder#setDefaultMemberPermissions() and other methods were wrongly omitted when adding options. Also fixed an issue where toJSON() returned the wrong type and fixed docs for TextInputBuilder#equals()

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested a review from a team as a code owner May 5, 2024 09:36
Copy link

vercel bot commented May 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview May 5, 2024 9:37am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview May 5, 2024 9:37am

@Jiralite Jiralite added this to the builders 1.8.1 milestone May 5, 2024
@kodiakhq kodiakhq bot merged commit 07c1210 into discordjs:main May 5, 2024
6 checks passed
@Qjuh Qjuh deleted the fix/builders-permissions branch May 6, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

setDMPermission and setDefaultMemberPermissions do not exist on type 'SlashCommandOptionsOnlyBuilder'
4 participants