fix(SlashCommandBuilder): add missing shared properties

[TAEMBO]

Please describe the changes this PR makes and why it should be merged:
Following #10253, other properties were observed to also not be present when using options or subcommands. This PR adds those properties on the type level where they are present during runtime.

Status and versioning classification:

• Code changes have been tested against the Discord API, or there are no code changes
• I know how to update typings and have done so, or typings don't need updating

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)	Visit Preview		May 15, 2024 1:51am
discord-js-guide	⬜️ Ignored (Inspect)	Visit Preview		May 15, 2024 1:51am

[Jiralite]

Do you mind providing an example of where this fails?

[Anonymous4078]

This should fix my issue

[TAEMBO]

Do you mind providing an example of where this fails?

import { SlashCommandBuilder } from "@discordjs/builders";

const command = new SlashCommandBuilder().setNSFW(true).addSubcommand(x => x);

command.nsfw; // Property 'nsfw' does not exist on type 'SlashCommandOptionsOnlyBuilder'.ts(2339)

console.log(command); // { ..., nsfw: true }

Node: v22.1.0
@discordjs/builders: v1.8.1
TypeScript: v5.4.5

Edit: I realize the error comment says "Options" however my code shows a subcommand - I was debugging the extent this issue reaches. For clarity, this issue is present when using both subcommands and options - using addStringOption() or any others will give the same result w/ SlashCommandOptionsOnlyBuilder or SlashCommandSubcommandsOnlyBuilder accordingly.

[vladfrangu]

Can you add in tests for this please, so we can be sure we don't make a regression again in the future 🙏

[TAEMBO]

Vitest doesn't allow us to enable type checking as proposed in Discord in these *.test.ts files, as it produces an error
Error: test.each syntax is not supported when testing types, of which there are 5 instances of that being used in /builders and /voice. Let me know how you guys would like to handle that - i.e. enable it anyways, skip it, or make other changes.

[vladfrangu]

Couldn't we have a separate test file just for types, and make vitest use type checking just in that one?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.89%. Comparing base (616208b) to head (d97372d).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main   #10255       +/-   ##
===========================================
+ Coverage   19.14%   95.89%   +76.75%     
===========================================
  Files          31       44       +13     
  Lines        6246     3634     -2612     
  Branches       73      111       +38     
===========================================
+ Hits         1196     3485     +2289     
+ Misses       5050      149     -4901     

Flag	Coverage Δ
brokers	95.89% <100.00%> (+76.75%)	⬆️
builders	95.89% <100.00%> (+76.75%)	⬆️
collection	95.89% <100.00%> (+76.75%)	⬆️
discord.js	95.89% <100.00%> (+76.75%)	⬆️
formatters	95.89% <100.00%> (+76.75%)	⬆️
guide	95.89% <100.00%> (+76.75%)	⬆️
next	95.89% <100.00%> (+76.75%)	⬆️
proxy	95.89% <100.00%> (+76.75%)	⬆️
rest	95.89% <100.00%> (+76.75%)	⬆️
util	95.89% <100.00%> (+76.75%)	⬆️
utilities	95.89% <100.00%> (+76.75%)	⬆️
voice	95.89% <100.00%> (+76.75%)	⬆️
website	95.89% <100.00%> (+76.75%)	⬆️
ws	95.89% <100.00%> (+76.75%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Resolved.