e2e tests for temporal data - RISDEV-3848

[hamo225]

No description provided.

[VictorDelCampo]

Hey @hamo225, this is my review:

1. I think we need a new e2e test for the side navigation where we test it separate? Or we just keep also the navigation within this test but then I would expect to be two describe-layers:
   • test navigation to time boundaries using navigation starting on /amending-laws/eli/bund/bgbl-1/2017/s419/2017-03-15/1/deu/regelungstext-1 and just check if you arrived at .../temporal-data
   • test the actual page including:
     • heading
     • Artikel 3Inkraftrete
     • the managing of the data itself meaning add/update/delete
2. For testing the heading I would use if possible something more readable like:

   await expect(
      page.getByRole("heading", { level: 1, name: "Artikel 1" }),
    ).toBeVisible()

3. Why do you need to do

    await page.waitForResponse(
      (response) =>
        response.url().includes("timeBoundaries") && response.status() === 200,
    )

Is the await saveButton.click() not enough for waiting? But this could be related to the next point

4. Why do you do the API calls to test the response JSON? In my opinion the E2E tests are done user-facing meaning what the user would se. I would just add/update/delete data, save, reload page and see if the data is there

[reckseba]

What about this PUT request? You are not expecting anything from it. And it does not change anything on the state.

[hamo225]

The PUT is not part of the user interaction. Its for the test, to set up and reset the environment. I have moved this into a function that will be called at the start and end of the test. This whole setup for the tests will change soon i hope.