Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set USWDS to false on process list and breadcrumbs #28491

Closed
wants to merge 3 commits into from

Conversation

micahchiang
Copy link
Contributor

@micahchiang micahchiang commented Mar 12, 2024

Summary

Design system team is setting the default version for web components to V3. Because the va-process-list and va-breadcrumbs is not forward compatible, we are setting current v1 instances of va-process-list and va-breadcrumbs to uswds="false" to prevent the update. No changes will occur because of this update.

Related issue(s)

Partial Formation Deprecation - set uswds prop to true on all components #2405

Testing done

  • Tested locally to make sure update caused no change.

What areas of the site does it impact?

Update is to ensure no change happens during web component update.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-force-v1-comps-branch-2/main March 12, 2024 04:16 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/mc-force-v1-comps-branch-2/main March 12, 2024 04:29 Inactive
@micahchiang micahchiang marked this pull request as ready for review March 12, 2024 04:35
@micahchiang micahchiang requested review from a team as code owners March 12, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants