New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly set uswds to false for va-process-list #28473
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 18:36
Inactive
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 19:02
Inactive
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 19:26
Inactive
micahchiang
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a lot, but really, it's mostly all formatting. The important parts are where uswds="false"
is being set on instances of the breadcrumb and process list web components.
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 21:13
Inactive
micahchiang
force-pushed
the
force-v1-va-process-list
branch
from
March 11, 2024 21:34
414e69a
to
6413153
Compare
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 21:39
Inactive
This reverts commit beed3b2.
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
micahchiang
force-pushed
the
force-v1-va-process-list
branch
from
March 11, 2024 21:49
6413153
to
ffd7f76
Compare
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 21:50
Inactive
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 23:02
Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 23:08
Inactive
This reverts commit 81f27c6.
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 23:14
Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 23:22
Inactive
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 23:28
Inactive
va-vfs-bot
temporarily deployed
to
master/force-v1-va-process-list/main
March 11, 2024 23:33
Inactive
Closing this as it will be handled in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Design system team is setting the default version for web components to V3. Because the
va-process-list
is not forward compatible, we are setting current v1 instances ofva-process-list
touswds="false"
to prevent the update. No changes will occur because of this update.Related issue(s)
Partial Formation Deprecation - set uswds prop to true on all components #2405
Testing done
Screenshots
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling