Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set uswds to false for va-process-list #28473

Closed
wants to merge 28 commits into from

Conversation

ataker
Copy link
Contributor

@ataker ataker commented Mar 11, 2024

Summary

Design system team is setting the default version for web components to V3. Because the va-process-list is not forward compatible, we are setting current v1 instances of va-process-list to uswds="false" to prevent the update. No changes will occur because of this update.

Related issue(s)

Partial Formation Deprecation - set uswds prop to true on all components #2405

Testing done

  • Tested locally to make sure update caused no change.

Screenshots

burial-intro-v6
fry-dea

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

@ataker ataker requested review from a team as code owners March 11, 2024 18:36
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 18:36 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 19:02 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 19:26 Inactive
@ataker ataker requested review from a team as code owners March 11, 2024 21:04
Copy link
Contributor

@micahchiang micahchiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a lot, but really, it's mostly all formatting. The important parts are where uswds="false" is being set on instances of the breadcrumb and process list web components.

@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 21:13 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 21:39 Inactive
This reverts commit beed3b2.
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 21:50 Inactive
This reverts commit 5d22d2b.
This reverts commit beed3b2.
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 23:02 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 23:08 Inactive
This reverts commit 81f27c6.
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 23:14 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 23:22 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 23:28 Inactive
This reverts commit 81b3c2b.
This reverts commit 54c4ee8.
@va-vfs-bot va-vfs-bot temporarily deployed to master/force-v1-va-process-list/main March 11, 2024 23:33 Inactive
@micahchiang micahchiang removed request for a team March 12, 2024 03:27
@ataker
Copy link
Contributor Author

ataker commented Mar 12, 2024

Closing this as it will be handled in this PR

@ataker ataker closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants