Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ver component-library to 38.0.0 #28486

Merged
merged 44 commits into from Mar 15, 2024
Merged

Conversation

it-harrison
Copy link
Contributor

Summary

This PR bumps the version of component-library to 38.0.0.

Related issue(s)

2476

Testing done

local unit testing

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@it-harrison it-harrison requested a review from a team as a code owner March 11, 2024 22:21
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 11, 2024 22:32 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 12, 2024 00:09 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 12, 2024 03:34 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 12, 2024 14:54 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 12, 2024 15:17 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 12, 2024 19:06 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 12, 2024 21:46 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 13, 2024 00:11 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 13, 2024 14:20 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 13, 2024 15:50 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 13, 2024 16:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 13, 2024 16:28 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 13, 2024 17:53 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 14, 2024 22:35 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@it-harrison it-harrison requested a review from a team as a code owner March 15, 2024 04:12
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 15, 2024 04:13 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 15, 2024 04:45 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 15, 2024 05:29 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-component-lib-38.0.0/main March 15, 2024 06:10 Inactive
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a Public Websites perspective!

Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ToddWebDev ToddWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the Pensions team

@jamigibbs jamigibbs self-requested a review March 15, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants