Fixed scroll/focus logic on close of modal #28266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/co-022824-Find-a-Rep-csrf-token/main
|
PR has failing required tests, opting not to review at this time. - Tier 2/FE COP |
va-vfs-bot
temporarily deployed
to
master/co-022824-Find-a-Rep-csrf-token/main
va-vfs-bot
temporarily deployed
to
master/co-022824-Find-a-Rep-csrf-token/main
…department-of-veterans-affairs/vets-website into co-022824-Find-a-Rep-csrf-token
va-vfs-bot
temporarily deployed
to
master/co-022824-Find-a-Rep-csrf-token/main
…department-of-veterans-affairs/vets-website into co-022824-Find-a-Rep-csrf-token
va-vfs-bot
temporarily deployed
to
master/co-022824-Find-a-Rep-csrf-token/main
va-vfs-bot
reviewed
Mar 4, 2024
There was a problem hiding this comment.
Sentry call found
Sentry captures a lot of data, and we want to make sure that we only keep information that will be useful for troubleshooting issues. This means that PII should not be recorded.
What you can do
Review your call to Sentry and see if you can reasonably reduce any information that is included, or wait for a VSP review.
src/applications/representative-search/actions/reports/submitRepresentativeReport.js
Show resolved
Hide resolved
va-vfs-bot
reviewed
Mar 4, 2024
src/applications/representative-search/components/results/ReportModal.jsx
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
master/co-022824-Find-a-Rep-csrf-token/main
micahchiang
approved these changes
Mar 4, 2024
pjhill
pushed a commit
that referenced
this pull request
Mar 14, 2024
* Fixed scroll/focus logic on close of modal * Updated feature toggle references to "find_a_representative_enabled" * Refactored scroll/focus logic. Now focuses alert when reports increase * Added new feature flag * Setting csrfToken on successful fetch. Using apiRequest utility rather than fetch. * Updated error verbiage * Setting report object properties to snake case items for API * Moved formatting logic to dedicated formatReportBody. Added unit test.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related issue(s)
Related issue(s)
New unit test written for method that formats reports