Co 021624 find a rep unit test and component changes #28034
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
reviewed
Feb 16, 2024
src/applications/representative-search/components/results/ReportModal.jsx
Show resolved
Hide resolved
va-vfs-bot
temporarily deployed
to
master/co-021624-Find-a-Rep-unit-test-and-component-changes/main
micahchiang
previously approved these changes
Feb 16, 2024
|
@micahchiang - review went stale after resolving a conflict (also caught a minor typo). Requesting re-approval, thanks! |
…https://github.com/department-of-veterans-affairs/vets-website into co-021624-Find-a-Rep-unit-test-and-component-changes
micahchiang
approved these changes
Feb 21, 2024
|
Closing this stale PR. Changes are present as of this subsequent PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Pertaining to comments from @micahchiang on an older PR:
#27936
Regarding the comment about converting the address link from an into a va-link component, I'm not sure how I could include the linebreak in the anchor text of the va-link component. @micahchiang do you have any thoughts?
Testing
Unit test was updated and continues to pass.