New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating component-library version to 37.1.0 #28248
Closed
Closed
Changes from 25 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
1c2e052
Updating component-library version
Andrew565 bca2ce5
Merge branch 'main' into update-comp-lib-37-1
Andrew565 553215f
Merge branch 'main' into update-comp-lib-37-1
Andrew565 d7cf917
Merge branch 'main' into update-comp-lib-37-1
jamigibbs d316b7c
Merge branch 'main' into update-comp-lib-37-1
jamigibbs f68587c
Merge branch 'main' into update-comp-lib-37-1
jamigibbs ce455e1
Merge branch 'main' into update-comp-lib-37-1
jamigibbs bc08634
Merge branch 'main' into update-comp-lib-37-1
Andrew565 8d90f30
try to fix test
jamigibbs 30c222d
Revert "try to fix test"
jamigibbs add39a8
Merge branch 'main' into update-comp-lib-37-1
jamigibbs ab34fd8
Merge branch 'main' into update-comp-lib-37-1
jamigibbs 25ed5b2
Merge branch 'main' into update-comp-lib-37-1
micahchiang 4a6a8a1
fix 10182 test
micahchiang 0d3aec2
Merge branch 'main' into update-comp-lib-37-1
micahchiang 251db10
Merge branch 'main' into update-comp-lib-37-1
Andrew565 54171be
update test
jamigibbs 131d573
try to get test to pass
jamigibbs 30f7c8a
Merge branch 'main' into update-comp-lib-37-1
jamigibbs abdccb2
revert test update
jamigibbs 1d44b20
Merge branch 'main' into update-comp-lib-37-1
jamigibbs 964c222
cleanup
jamigibbs 80a0103
Skipping flaky test
Andrew565 503aac6
Merge branch 'main' into update-comp-lib-37-1
micahchiang a30e940
skip mhv tests with improper selectors
micahchiang 9d08e63
Adding force: true to a secure messaging test
Andrew565 433b1e5
Adding {force:true} to another click test
Andrew565 3155fbd
Adding more force:trues to category clicks
Andrew565 b5cd2b1
Merge branch 'main' into update-comp-lib-37-1
Andrew565 d74a60f
Merge branch 'main' into update-comp-lib-37-1
Andrew565 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@department-of-veterans-affairs/vfs-mhv-secure-messaging - I've skipped the below test suite for the time being. It fails consistently on looking for attributes that don't seem to exist when cypress is querying the dom:
It's looking for an element with the
close-btn-aria-label
attribute, but it seems like this selector is intended for a va-alert, not the modal that Cypress is rendering.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fazilqa @haniasma ☝🏻