Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating component-library version to 37.1.0 #28248

Closed
wants to merge 30 commits into from
Closed

Conversation

Andrew565
Copy link
Contributor

Summary

Updating component-library to version 37.1.0

Testing done

No testing done.

Screenshots

N/A

What areas of the site does it impact?

Updates component-library dependency to latest version.

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main February 29, 2024 14:04 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main February 29, 2024 20:18 Inactive
jamigibbs
jamigibbs previously approved these changes Feb 29, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main February 29, 2024 21:44 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 1, 2024 14:25 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 1, 2024 16:01 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 1, 2024 19:40 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 1, 2024 23:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 4, 2024 17:23 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@Andrew565 Andrew565 requested a review from a team as a code owner March 4, 2024 19:32
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 4, 2024 19:40 Inactive
@Andrew565 Andrew565 requested a review from a team as a code owner March 5, 2024 20:23
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 5, 2024 20:51 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 5, 2024 21:15 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 5, 2024 21:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 5, 2024 21:58 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 5, 2024 23:02 Inactive
Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
@Andrew565 Andrew565 requested a review from a team as a code owner March 6, 2024 00:45
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 6, 2024 00:46 Inactive
micahchiang
micahchiang previously approved these changes Mar 6, 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@department-of-veterans-affairs/vfs-mhv-secure-messaging - I've skipped the below test suite for the time being. It fails consistently on looking for attributes that don't seem to exist when cypress is querying the dom:

image

It's looking for an element with the close-btn-aria-label attribute, but it seems like this selector is intended for a va-alert, not the modal that Cypress is rendering.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 6, 2024 11:39 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 6, 2024 14:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 6, 2024 14:31 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/update-comp-lib-37-1/main March 6, 2024 17:22 Inactive
@Andrew565
Copy link
Contributor Author

Closing in favor of 37.2 release

@Andrew565 Andrew565 closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants