Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Co 021624 find a rep unit test and component changes #28034

Closed
wants to merge 5 commits into from
Closed

Co 021624 find a rep unit test and component changes #28034

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7bf5b2
Removed whitespace from unit test
cosu419 Feb 16, 2024
ba6691e
Explicitly setting property in snake case with eslint camelcase disabled
cosu419 Feb 16, 2024
497c987
Merge branch 'main' into co-021624-Find-a-Rep-unit-test-and-component…
cosu419 Feb 20, 2024
bf8b42a
Typo
cosu419 Feb 20, 2024
a72c10d
Merge branch 'co-021624-Find-a-Rep-unit-test-and-component-changes' o…
cosu419 Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/applications/representative-search/components/results/ReportModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import {
VaModal,
VaCheckboxGroup,
} from '@department-of-veterans-affairs/component-library/dist/react-bindings';
import { snakeCase } from 'lodash';

const ReportModal = ({
representativeName,
Expand Down Expand Up @@ -82,8 +81,8 @@ const ReportModal = ({
Object.keys(reportObject).forEach(prop => {
if (reportObject[prop] !== null) {
if (prop === 'phone') {
formattedReportObject.reports[snakeCase('phoneNumber')] =
reportObject.phone;
/* eslint-disable-next-line camelcase */
cosu419 marked this conversation as resolved.
Show resolved Hide resolved
formattedReportObject.phone_number = reportObject.phone;
} else {
formattedReportObject.reports[prop] = reportObject[prop];
}
Expand Down
2 changes: 1 addition & 1 deletion src/applications/representative-search/tests/components/SearchResultsHeader.unit.spec.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ describe('SearchResultsHeader', () => {
);

const expectedString =
'Showing1-10of12resultsfor"Accreditedattorney"within"50miles"of"newyork"';
'Showing 1-10 of 12 results fo r"Accredited attorney" within "50 miles" of "new york"';
const actualString = wrapper.find('h3').text();

// Remove whitespaces and special characters
Expand Down