New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Delete Value UI Bug #171
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
d6145cc
added logs to figure out what's going on
mdelez e624b07
Merge branch 'master' into fix/dsp-550-delete-value-ui-bug
mdelez 1d04860
fix (resource-viewer): fixed bug where a recently updated value will …
mdelez e8a0e73
Merge branch 'master' into fix/dsp-550-delete-value-ui-bug
mdelez 8456ebb
fix (e2e): fixed e2e tests
mdelez 094ad31
Merge branch 'master' into fix/dsp-550-delete-value-ui-bug
mdelez 2515894
Merge branch 'master' into fix/dsp-550-delete-value-ui-bug
mdelez dda33f8
refactor (resource-view): value operation event subscription is now a…
mdelez 1f8da1e
make the subscription array variable plural...
mdelez f122a36
refactor (resource-view): split the updateResource method into three …
mdelez 0208677
fix (resource-view): added a new method in the value-type.service to …
mdelez 4768a6b
added comment for clarification on why we need to get the DOM element…
mdelez fd17180
refactor (value operation event service): added subclasses for each v…
mdelez File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -62,6 +62,20 @@ export class ValueTypeService { | |
} | ||
} | ||
|
||
/** | ||
* Given the ObjectType of a PropertyDefinition, compares it to the type of the type of the provided value. | ||
* Primarily used to check if a TextValue type is equal to one of the readonly strings in this class. | ||
* | ||
* @param objectType PropertyDefinition ObjectType | ||
* @param valueType Value type (ReadValue, DeleteValue, BaseValue, etc.) | ||
*/ | ||
compareObjectTypeWithValueType(objectType: string, valueType: string): boolean { | ||
return objectType === this._readTextValueAsString || | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. sorry for the late notice but I think there is some missing conditions: (valueType === Constants.TextValue && objectType === this._readTextValueAsString) || ... Otherwise text values are always included. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. fixed in #175 |
||
objectType === this._readTextValueAsHtml || | ||
objectType === this._readTextValueAsXml || | ||
objectType === valueType; | ||
} | ||
|
||
/** | ||
* Equality checks with constants below are TEMPORARY until component is implemented. | ||
* Used so that the CRUD buttons do not show if a property doesn't have a value component. | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a comment that this is necessary because the DOM element has been re-created
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in 4768a6b