Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Delete Value UI Bug #171

Merged
merged 13 commits into from Sep 14, 2020
Merged

FIX: Delete Value UI Bug #171

merged 13 commits into from Sep 14, 2020

Commits on Aug 28, 2020

  1. added logs to figure out what's going on

    @mdelez
    mdelez committed Aug 28, 2020
    Copy the full SHA
    d6145cc View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2020

  1. Merge branch 'master' into fix/dsp-550-delete-value-ui-bug

    @mdelez
    mdelez committed Sep 8, 2020
    Copy the full SHA
    e624b07 View commit details
    Browse the repository at this point in the history

  2. fix (resource-viewer): fixed bug where a recently updated value will … 

    …not be removed from the UI when deleted
    @mdelez
    mdelez committed Sep 8, 2020
    Copy the full SHA
    1d04860 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix/dsp-550-delete-value-ui-bug

    @mdelez
    mdelez committed Sep 8, 2020
    Copy the full SHA
    e8a0e73 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2020

  1. fix (e2e): fixed e2e tests

    @mdelez
    mdelez committed Sep 9, 2020
    Copy the full SHA
    8456ebb View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix/dsp-550-delete-value-ui-bug

    @mdelez
    mdelez committed Sep 9, 2020
    Copy the full SHA
    094ad31 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2020

  1. Merge branch 'master' into fix/dsp-550-delete-value-ui-bug

    @mdelez
    mdelez committed Sep 14, 2020
    Copy the full SHA
    2515894 View commit details
    Browse the repository at this point in the history

  2. refactor (resource-view): value operation event subscription is now a… 

    …n array and the subscriptions are added to it
    @mdelez
    mdelez committed Sep 14, 2020
    Copy the full SHA
    dda33f8 View commit details
    Browse the repository at this point in the history

  3. make the subscription array variable plural...

    @mdelez
    mdelez committed Sep 14, 2020
    Copy the full SHA
    1f8da1e View commit details
    Browse the repository at this point in the history

  4. refactor (resource-view): split the updateResource method into three … 

    …smaller methods that are easier to understand
    @mdelez
    mdelez committed Sep 14, 2020
    Copy the full SHA
    f122a36 View commit details
    Browse the repository at this point in the history

  5. fix (resource-view): added a new method in the value-type.service to … 

    …check if the objectType of a PropertyDefinition is equal to one of the readonly strings defined in the value-type.service for text values
    @mdelez
    mdelez committed Sep 14, 2020
    Copy the full SHA
    0208677 View commit details
    Browse the repository at this point in the history

  6. added comment for clarification on why we need to get the DOM element… 

    … again after updating a value
    @mdelez
    mdelez committed Sep 14, 2020
    Copy the full SHA
    4768a6b View commit details
    Browse the repository at this point in the history

  7. refactor (value operation event service): added subclasses for each v… 

    …alue operation
    @mdelez
    mdelez committed Sep 14, 2020
    Copy the full SHA
    fd17180 View commit details
    Browse the repository at this point in the history