Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: xmlupload crashes without writing id2iri mapping (DEV-813) #194

Merged
merged 42 commits into from Jun 17, 2022
Merged

fix: xmlupload crashes without writing id2iri mapping (DEV-813) #194

Show file tree
Hide file tree
Changes from 41 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
eaae265
catch BaseException when connection crashes, write mapping
jnussbaum May 25, 2022
923f7ce
cover more cases
jnussbaum May 25, 2022
e3f2be7
Merge branch 'main' into wip/dev-813-write-id2iri-mapping-when-xmlupl…
jnussbaum May 25, 2022
80b8564
continue
jnussbaum May 30, 2022
20eae27
Merge remote-tracking branch 'origin/wip/dev-813-write-id2iri-mapping…
jnussbaum May 30, 2022
30438aa
improve error handling
jnussbaum May 31, 2022
3ac9ee7
adapt same error handling to resource creation
jnussbaum May 31, 2022
e387588
adapt same error handling to both update functions
jnussbaum May 31, 2022
7e5dd46
Merge branch 'main' into wip/dev-813-write-id2iri-mapping-when-xmlupl…
jnussbaum Jun 1, 2022
018f456
remove salsah-link from testdata/test-id2iri-data.xml
jnussbaum Jun 1, 2022
77ca482
improve error catching
jnussbaum Jun 7, 2022
f5c453b
raise BaseError if salsah-link point to invalid internal ID, so that …
jnussbaum Jun 7, 2022
60c83bd
catch BaseError if sipi upload fails, so that this resource can be sk…
jnussbaum Jun 7, 2022
f759257
adapt same solution to both update methods
jnussbaum Jun 9, 2022
fa477c7
write both stashes into files if necessary
jnussbaum Jun 9, 2022
63792d8
fix typo
jnussbaum Jun 9, 2022
f440450
refactoring
jnussbaum Jun 9, 2022
63418bc
remove unused try-except clauses
jnussbaum Jun 9, 2022
ed13131
refactor
jnussbaum Jun 9, 2022
1ddf7a3
improve variable names
jnussbaum Jun 10, 2022
67a7382
catch BaseExceptions while updating the stashes
jnussbaum Jun 10, 2022
769b178
Merge branch 'main' into wip/dev-813-write-id2iri-mapping-when-xmlupl…
jnussbaum Jun 10, 2022
d534b0d
remove code smell
jnussbaum Jun 10, 2022
c69be05
replace dysfunctional MP4 testfile
jnussbaum Jun 10, 2022
47849d1
e2e test asserts that xmlupload ends without any unsuccessful uploads
jnussbaum Jun 10, 2022
7745c92
replace knora by DSP
jnussbaum Jun 13, 2022
61b5a64
instead of exit(1): handle_upload_error() re-raises the original error
jnussbaum Jun 13, 2022
6e84eed
rename 'update_stashed...()' to 'upload_stashed...()'
jnussbaum Jun 13, 2022
6d860cc
improve architecture of try_sipi_upload()
jnussbaum Jun 13, 2022
a16e328
correct typos
jnussbaum Jun 13, 2022
ef18641
postpone method-hiding to later
jnussbaum Jun 13, 2022
ffefa2a
correct typos in docstrings
jnussbaum Jun 13, 2022
857806c
- instead of exit(1), xml_upload() returns bool to show if everythin…
jnussbaum Jun 13, 2022
01fe081
sleep for 1,2,4,8,16 seconds instead of 5*1 second
jnussbaum Jun 13, 2022
62dba52
sleep longer
jnussbaum Jun 14, 2022
26da262
don't try to upload stash to a non-existing resource
jnussbaum Jun 14, 2022
8392c6f
refactor
jnussbaum Jun 14, 2022
e14a969
'upload' stash instead of 'update' stash
jnussbaum Jun 14, 2022
9d08042
improve terminal output and content of log files
jnussbaum Jun 14, 2022
618cfd5
refactor: put all network actions in a wrapper method
jnussbaum Jun 15, 2022
ba29da5
adapt tests
jnussbaum Jun 15, 2022
efdd4ae
apply reviewer's feedback
jnussbaum Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view