Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: xmlupload crashes without writing id2iri mapping (DEV-813) #194

Merged
merged 42 commits into from Jun 17, 2022
Merged

fix: xmlupload crashes without writing id2iri mapping (DEV-813) #194

merged 42 commits into from Jun 17, 2022

Commits on May 25, 2022

  1. catch BaseException when connection crashes, write mapping

    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    eaae265 View commit details
    Browse the repository at this point in the history

  2. cover more cases

    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    923f7ce View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into wip/dev-813-write-id2iri-mapping-when-xmlupl… 

    …oad-crashes
    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    e3f2be7 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2022

  1. continue

    @jnussbaum
    jnussbaum committed May 30, 2022
    Copy the full SHA
    80b8564 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/wip/dev-813-write-id2iri-mapping… 

    …-when-xmlupload-crashes' into wip/dev-813-write-id2iri-mapping-when-xmlupload-crashes
    @jnussbaum
    jnussbaum committed May 30, 2022
    Copy the full SHA
    20eae27 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. improve error handling

    @jnussbaum
    jnussbaum committed May 31, 2022
    Copy the full SHA
    30438aa View commit details
    Browse the repository at this point in the history

  2. adapt same error handling to resource creation

    @jnussbaum
    jnussbaum committed May 31, 2022
    Copy the full SHA
    3ac9ee7 View commit details
    Browse the repository at this point in the history

  3. adapt same error handling to both update functions

    @jnussbaum
    jnussbaum committed May 31, 2022
    Copy the full SHA
    e387588 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Merge branch 'main' into wip/dev-813-write-id2iri-mapping-when-xmlupl… 

    …oad-crashes
    @jnussbaum
    jnussbaum committed Jun 1, 2022
    Copy the full SHA
    7e5dd46 View commit details
    Browse the repository at this point in the history

  2. remove salsah-link from testdata/test-id2iri-data.xml

    @jnussbaum
    jnussbaum committed Jun 1, 2022
    Copy the full SHA
    018f456 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2022

  1. improve error catching

    @jnussbaum
    jnussbaum committed Jun 7, 2022
    Copy the full SHA
    77ca482 View commit details
    Browse the repository at this point in the history

  2. raise BaseError if salsah-link point to invalid internal ID, so that … 

    …this resource can be skipped instead of making the xmlupload crash
    @jnussbaum
    jnussbaum committed Jun 7, 2022
    Copy the full SHA
    f5c453b View commit details
    Browse the repository at this point in the history

  3. catch BaseError if sipi upload fails, so that this resource can be sk… 

    …ipped instead of making the xmlupload crash
    @jnussbaum
    jnussbaum committed Jun 7, 2022
    Copy the full SHA
    60c83bd View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. adapt same solution to both update methods 

    reduce number of retries to 5
    @jnussbaum
    jnussbaum committed Jun 9, 2022
    Copy the full SHA
    f759257 View commit details
    Browse the repository at this point in the history

  2. write both stashes into files if necessary

    @jnussbaum
    jnussbaum committed Jun 9, 2022
    Copy the full SHA
    fa477c7 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @jnussbaum
    jnussbaum committed Jun 9, 2022
    Copy the full SHA
    63792d8 View commit details
    Browse the repository at this point in the history

  4. refactoring

    @jnussbaum
    jnussbaum committed Jun 9, 2022
    Copy the full SHA
    f440450 View commit details
    Browse the repository at this point in the history

  5. remove unused try-except clauses

    @jnussbaum
    jnussbaum committed Jun 9, 2022
    Copy the full SHA
    63418bc View commit details
    Browse the repository at this point in the history

  6. refactor

    @jnussbaum
    jnussbaum committed Jun 9, 2022
    Copy the full SHA
    ed13131 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. improve variable names 

    rearrange code lines
improve comments
add docstrings
    @jnussbaum
    jnussbaum committed Jun 10, 2022
    Copy the full SHA
    1ddf7a3 View commit details
    Browse the repository at this point in the history

  2. catch BaseExceptions while updating the stashes

    @jnussbaum
    jnussbaum committed Jun 10, 2022
    Copy the full SHA
    67a7382 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into wip/dev-813-write-id2iri-mapping-when-xmlupl… 

    …oad-crashes
    @jnussbaum
    jnussbaum committed Jun 10, 2022
    Copy the full SHA
    769b178 View commit details
    Browse the repository at this point in the history

  4. remove code smell

    @jnussbaum
    jnussbaum committed Jun 10, 2022
    Copy the full SHA
    d534b0d View commit details
    Browse the repository at this point in the history

  5. replace dysfunctional MP4 testfile

    @jnussbaum
    jnussbaum committed Jun 10, 2022
    Copy the full SHA
    c69be05 View commit details
    Browse the repository at this point in the history

  6. e2e test asserts that xmlupload ends without any unsuccessful uploads

    @jnussbaum
    jnussbaum committed Jun 10, 2022
    Copy the full SHA
    47849d1 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. replace knora by DSP

    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    7745c92 View commit details
    Browse the repository at this point in the history

  2. instead of exit(1): handle_upload_error() re-raises the original error

    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    61b5a64 View commit details
    Browse the repository at this point in the history

  3. rename 'update_stashed...()' to 'upload_stashed...()'

    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    6e84eed View commit details
    Browse the repository at this point in the history

  4. improve architecture of try_sipi_upload()

    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    6d860cc View commit details
    Browse the repository at this point in the history

  5. correct typos 

    rename answer to response
improve comments/docstrings
    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    a16e328 View commit details
    Browse the repository at this point in the history

  6. postpone method-hiding to later

    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    ef18641 View commit details
    Browse the repository at this point in the history

  7. correct typos in docstrings

    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    ffefa2a View commit details
    Browse the repository at this point in the history

  8. - instead of exit(1), xml_upload() returns bool to show if everythin… 

    …g was successful

 - refactor e2e test accordingly
    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    857806c View commit details
    Browse the repository at this point in the history

  9. sleep for 1,2,4,8,16 seconds instead of 5*1 second

    @jnussbaum
    jnussbaum committed Jun 13, 2022
    Copy the full SHA
    01fe081 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. sleep longer 

    improve reconnecting-print
    @jnussbaum
    jnussbaum committed Jun 14, 2022
    Copy the full SHA
    62dba52 View commit details
    Browse the repository at this point in the history

  2. don't try to upload stash to a non-existing resource

    @jnussbaum
    jnussbaum committed Jun 14, 2022
    Copy the full SHA
    26da262 View commit details
    Browse the repository at this point in the history

  3. refactor

    @jnussbaum
    jnussbaum committed Jun 14, 2022
    Copy the full SHA
    8392c6f View commit details
    Browse the repository at this point in the history

  4. 'upload' stash instead of 'update' stash

    @jnussbaum
    jnussbaum committed Jun 14, 2022
    Copy the full SHA
    e14a969 View commit details
    Browse the repository at this point in the history

  5. improve terminal output and content of log files

    @jnussbaum
    jnussbaum committed Jun 14, 2022
    Copy the full SHA
    9d08042 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. refactor: put all network actions in a wrapper method

    @jnussbaum
    jnussbaum committed Jun 15, 2022
    Copy the full SHA
    618cfd5 View commit details
    Browse the repository at this point in the history

  2. adapt tests

    @jnussbaum
    jnussbaum committed Jun 15, 2022
    Copy the full SHA
    ba29da5 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2022

  1. apply reviewer's feedback

    @jnussbaum
    jnussbaum committed Jun 17, 2022
    Copy the full SHA
    efdd4ae View commit details
    Browse the repository at this point in the history