New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(onto validation): correctly identify circular dependencies (DEV-769) #192
Merged
Merged
Changes from 32 commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
5e552df
add draft-script to detect circles
4e3b71b
add more description to draft
68cb973
add more description to draft
4c632e4
fix
7863ef8
add shortname to resource names
b078b97
add circle detection and error message
a775d49
outsource a part of a method
a199860
add description
86d69b8
test script
bced991
deactivate load_ontology
32c656a
fix in circle finder
2467def
fix
ea8a563
add description
400d113
fix and add formatting
856bd18
add draft circle_detection with networx library
fa8b0fa
add methods and description
cc23c70
adjust Pipfile
3a5b166
adjust setup.py
652db32
fix onto_validate.py
b472500
add description
e28fc67
add description and update onto_validate.py
e24562b
rectify onto_validate.py
d9cb1a5
adjust error message
b46c4b8
Merge branch 'main' into wip/dev-769-onto-validation-circular
jnussbaum 5095725
delete unused files
jnussbaum e80c67c
revert manual change of setup.py
jnussbaum 380d7c3
pipenv install networkx
jnussbaum 8be6a0f
refactor code to improve readability
jnussbaum 3903db9
refactor code to improve readability
jnussbaum 07cffcf
continue work
jnussbaum 751294d
working solution
jnussbaum f7475d2
improve circle recognition
jnussbaum a4d6503
take into account
jnussbaum 301664f
refactor code to make it testable
jnussbaum e02dc46
extend test-onto for circularity-test
jnussbaum 62c766c
make separate onto for circularity-test
jnussbaum cda67c6
improve code testability
jnussbaum eb7c29f
save circular as file, to make it reusable
jnussbaum f5c482d
Apply suggestions from code review
jnussbaum File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a really neat solution for the problem, congratulations!