Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(onto validation): correctly identify circular dependencies (DEV-769) #192

Merged
merged 39 commits into from May 25, 2022
Merged

fix(onto validation): correctly identify circular dependencies (DEV-769) #192

merged 39 commits into from May 25, 2022

Commits on May 3, 2022

  1. add draft-script to detect circles

    gNahcab committed May 3, 2022
    Copy the full SHA
    5e552df View commit details
    Browse the repository at this point in the history

  2. add more description to draft

    gNahcab committed May 3, 2022
    Copy the full SHA
    4e3b71b View commit details
    Browse the repository at this point in the history

  3. add more description to draft

    gNahcab committed May 3, 2022
    Copy the full SHA
    68cb973 View commit details
    Browse the repository at this point in the history

  4. fix

    gNahcab committed May 3, 2022
    Copy the full SHA
    4c632e4 View commit details
    Browse the repository at this point in the history

  5. add shortname to resource names

    gNahcab committed May 3, 2022
    Copy the full SHA
    7863ef8 View commit details
    Browse the repository at this point in the history

  6. add circle detection and error message

    gNahcab committed May 3, 2022
    Copy the full SHA
    b078b97 View commit details
    Browse the repository at this point in the history

  7. outsource a part of a method

    gNahcab committed May 3, 2022
    Copy the full SHA
    a775d49 View commit details
    Browse the repository at this point in the history

  8. add description

    gNahcab committed May 3, 2022
    Copy the full SHA
    a199860 View commit details
    Browse the repository at this point in the history

  9. test script

    gNahcab committed May 3, 2022
    Copy the full SHA
    86d69b8 View commit details
    Browse the repository at this point in the history

  10. deactivate load_ontology

    gNahcab committed May 3, 2022
    Copy the full SHA
    bced991 View commit details
    Browse the repository at this point in the history

  11. fix in circle finder

    gNahcab committed May 3, 2022
    Copy the full SHA
    32c656a View commit details
    Browse the repository at this point in the history

  12. fix

    gNahcab committed May 3, 2022
    Copy the full SHA
    2467def View commit details
    Browse the repository at this point in the history

  13. add description

    gNahcab committed May 3, 2022
    Copy the full SHA
    ea8a563 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2022

  1. fix and add formatting

    gNahcab committed May 4, 2022
    Copy the full SHA
    400d113 View commit details
    Browse the repository at this point in the history

  2. add draft circle_detection with networx library

    gNahcab committed May 4, 2022
    Copy the full SHA
    856bd18 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. add methods and description

    gNahcab committed May 9, 2022
    Copy the full SHA
    fa8b0fa View commit details
    Browse the repository at this point in the history

  2. adjust Pipfile

    gNahcab committed May 9, 2022
    Copy the full SHA
    cc23c70 View commit details
    Browse the repository at this point in the history

  3. adjust setup.py

    gNahcab committed May 9, 2022
    Copy the full SHA
    3a5b166 View commit details
    Browse the repository at this point in the history

  4. fix onto_validate.py

    gNahcab committed May 9, 2022
    Copy the full SHA
    652db32 View commit details
    Browse the repository at this point in the history

  5. add description

    gNahcab committed May 9, 2022
    Copy the full SHA
    b472500 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2022

  1. add description and update onto_validate.py

    gNahcab committed May 10, 2022
    Copy the full SHA
    e28fc67 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2022

  1. rectify onto_validate.py 

    delete circle_detection_validate.py
    gNahcab committed May 16, 2022
    Copy the full SHA
    e24562b View commit details
    Browse the repository at this point in the history

  2. adjust error message

    gNahcab committed May 16, 2022
    Copy the full SHA
    d9cb1a5 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into wip/dev-769-onto-validation-circular

    @jnussbaum
    jnussbaum committed May 16, 2022
    Copy the full SHA
    b46c4b8 View commit details
    Browse the repository at this point in the history

  4. delete unused files

    @jnussbaum
    jnussbaum committed May 16, 2022
    Copy the full SHA
    5095725 View commit details
    Browse the repository at this point in the history

  5. revert manual change of setup.py

    @jnussbaum
    jnussbaum committed May 16, 2022
    Copy the full SHA
    e80c67c View commit details
    Browse the repository at this point in the history

  6. pipenv install networkx 

    make freeze-requirements
    @jnussbaum
    jnussbaum committed May 16, 2022
    Copy the full SHA
    380d7c3 View commit details
    Browse the repository at this point in the history

  7. refactor code to improve readability

    @jnussbaum
    jnussbaum committed May 16, 2022
    Copy the full SHA
    8be6a0f View commit details
    Browse the repository at this point in the history

  8. refactor code to improve readability

    @jnussbaum
    jnussbaum committed May 16, 2022
    Copy the full SHA
    3903db9 View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. continue work

    @jnussbaum
    jnussbaum committed May 19, 2022
    Copy the full SHA
    07cffcf View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. working solution

    @jnussbaum
    jnussbaum committed May 23, 2022
    Copy the full SHA
    751294d View commit details
    Browse the repository at this point in the history

  2. improve circle recognition

    @jnussbaum
    jnussbaum committed May 23, 2022
    Copy the full SHA
    f7475d2 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. take into account 

     - base properties derived from hasLinkTo
 - user-defined properties derived from the above
    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    a4d6503 View commit details
    Browse the repository at this point in the history

  2. refactor code to make it testable

    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    301664f View commit details
    Browse the repository at this point in the history

  3. extend test-onto for circularity-test

    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    e02dc46 View commit details
    Browse the repository at this point in the history

  4. make separate onto for circularity-test

    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    62c766c View commit details
    Browse the repository at this point in the history

  5. improve code testability

    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    cda67c6 View commit details
    Browse the repository at this point in the history

  6. save circular as file, to make it reusable

    @jnussbaum
    jnussbaum committed May 25, 2022
    Copy the full SHA
    eb7c29f View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: irinaschubert <irina.schubert@dasch.swiss>
    @jnussbaum
    jnussbaum and irinaschubert committed May 25, 2022
    Copy the full SHA
    f5c482d View commit details
    Browse the repository at this point in the history