New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(file value uploads): use upload from for file value types #361
Closed
Closed
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
332e575
feat(resource creation): check for file values
e33e490
feat(resource creation): check for file values
6785db6
feat(resource creation): integrate upload form
8a4c6b3
feat(resource creation): make template prop access save
1552b92
feat(resource creation): integrate upload form
fa466d4
Merge branch 'main' into wip/dsp-1203-file-upload
tobiasschweizer 6f085e7
feat(resource creation): integrate upload form
ad98f90
feat(resource creation): integrate upload form
5b4dce9
feat(resource creation): integrate upload form
684e70b
chore(package.json): update dsp-js
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flavens @mpro7 I added Outputs to the upload file component.
My idea is that on a successful file upload, a
CreateStillImageFileValue
can be created. However, I am not sure where this should happen. WouldSelectPropertiesComponent
be the right place to handle this?I have added some logic for the upload to
ResourceInstanceFormComponent
, but maybe this should be moved toSelectPropertiesComponent
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe instead of the Outputs,
UploadFileComponent
's form could be used: as long as there is no successful upload to Sipi, the form is invalid.UploadFileComponent
would have to be added topropertiesParentForm
then.But then instead of the binary file (
File
), theUploadedFileResponse
obtained from Sipi should be stored in theFormControl
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tobiasschweizer IMO FormControl has to be used anyway, so second options sounds good for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, I'll try that approach next week.