Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(file value uploads): use upload from for file value types #361

Closed
wants to merge 10 commits into from

Conversation

tobiasschweizer
Copy link
Contributor

resolves DSP-1203

@tobiasschweizer tobiasschweizer self-assigned this Jan 15, 2021
@tobiasschweizer tobiasschweizer marked this pull request as draft January 15, 2021 09:13
@tobiasschweizer
Copy link
Contributor Author

@flavens I integrated the upload form. However, now we need to figure out how to get the tmp. file name from Sipi and then create the CreateStillImageFileValue class. I guess we would need some help from @mpro7.

prop => !binaryTypes.includes(prop.objectType)
);

// TODO: add a FormControl representing the file value to propertiesParentForm
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flavens @mpro7 I added Outputs to the upload file component.

My idea is that on a successful file upload, a CreateStillImageFileValue can be created. However, I am not sure where this should happen. Would SelectPropertiesComponent be the right place to handle this?

I have added some logic for the upload to ResourceInstanceFormComponent, but maybe this should be moved to SelectPropertiesComponent.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe instead of the Outputs, UploadFileComponent's form could be used: as long as there is no successful upload to Sipi, the form is invalid. UploadFileComponent would have to be added to propertiesParentForm then.

But then instead of the binary file (File), the UploadedFileResponse obtained from Sipi should be stored in the FormControl.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tobiasschweizer IMO FormControl has to be used anyway, so second options sounds good for me.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I'll try that approach next week.

@flavens
Copy link
Contributor

flavens commented Jan 28, 2021

@tobiasschweizer please do not update this branch from main (we will explain during the daily scrum)

@tobiasschweizer
Copy link
Contributor Author

@tobiasschweizer please do not update this branch from main (we will explain during the daily scrum)

I figure it is because you removed everything but the admin part from main.

@kilchenmann
Copy link
Contributor

This is done in #472

@kilchenmann kilchenmann deleted the wip/dsp-1203-file-upload branch January 19, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants