Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG entries #1488

Merged
merged 2 commits into from Apr 18, 2024
Merged

Conversation

manicmaniac
Copy link
Member

@ydah Thank you for your recent contributions. Could I add them to the change log?

@manicmaniac manicmaniac self-assigned this Apr 18, 2024
Copy link
Contributor

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not included in the CHANGELOG because the change had no effect on users. Thank you for adding it!

@manicmaniac
Copy link
Member Author

Let me check the rule... 👀

The big one is we request that every code change to Danger include a CHANGELOG entry,
this is so that:
1. People know what changes are between versions
2. Orta doesn't get all the credit for other people's work

Danger will look for a modification to the `CHANGELOG.md` when there are changes including
`lib/*` - if you're fixing unreleased code, or doing a simple typo change, you can
include `#trivial` in the title or the body of the PR and this is skipped.

And the older entries... 👀

* Add Ruby 3.2 to test matrix [@mataku](https://github.com/mataku) [#1434](https://github.com/danger/danger/pull/1434)

I think #1486 and #1487 deserve to be explained in the change log.

I will remove #1485 because @ydah explicitly tagged it as #trivial.

@manicmaniac manicmaniac requested a review from ydah April 18, 2024 02:09
Copy link
Contributor

@ydah ydah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for checking! And sorry I forgot to update CHANGELOG 🙇

@manicmaniac manicmaniac merged commit b5e62e8 into danger:master Apr 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants