Skip to content

Commit

Permalink
Merge pull request #1485 from ydah/fix-typos
Browse files Browse the repository at this point in the history
Fix some typos #trivial
  • Loading branch information
manicmaniac committed Apr 18, 2024
2 parents f7786f4 + 48b386c commit 84f0721
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion lib/danger/ci_source/buildkite.rb
Expand Up @@ -7,7 +7,7 @@ module Danger
# ### CI Setup
#
# With BuildKite you run the server yourself, so you will want to run it as a part of your build process.
# It is common to have build steps, so we would recommend adding this to your scrip:
# It is common to have build steps, so we would recommend adding this to your script:
#
# ```shell
# echo "--- Running Danger"
Expand Down
2 changes: 1 addition & 1 deletion lib/danger/helpers/comments_helper.rb
Expand Up @@ -35,7 +35,7 @@ def markdown_link_to_message(message, hide_link)
#
# request_source implementations are invited to override this method.
# This is mostly here to enable sources to detect when inlines change only in their
# commit hash and not in content per-se. since the link is implementation dependant
# commit hash and not in content per-se. since the link is implementation dependent
# so should be the comparison.
#
# @param [Violation or Markdown] m1
Expand Down
2 changes: 1 addition & 1 deletion lib/danger/request_sources/vsts.rb
Expand Up @@ -139,7 +139,7 @@ def update_old_comment(new_comment, danger_id: "danger")
end

def submit_inline_comments!(warnings: [], errors: [], messages: [], markdowns: [], previous_violations: [], danger_id: "danger")
# Avoid doing any fetchs if there's no inline comments
# Avoid doing any fetches if there's no inline comments
return {} if (warnings + errors + messages + markdowns).select(&:inline?).empty?

pr_threads = @api.fetch_last_comments
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/danger/ci_sources/circle_spec.rb
Expand Up @@ -89,7 +89,7 @@
expect(described_class.validates_as_pr?(invalid_env)).to be false
end

it "doest not validate when required env variables are not set" do
it "does not validate when required env variables are not set" do
expect(described_class.validates_as_pr?(invalid_env)).to be false
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/danger/commands/local_helpers/pry_setup_spec.rb
Expand Up @@ -19,7 +19,7 @@
end
end

it "doesn't copy a nonexistant Dangerfile" do
it "doesn't copy a nonexistent Dangerfile" do
described_class.new(testing_ui).setup_pry("", "pr")

expect(File).not_to exist("_Dangerfile.tmp")
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/danger/commands/runner_spec.rb
Expand Up @@ -16,7 +16,7 @@
end

context "default options" do
it "sets instance variables accrodingly" do
it "sets instance variables accordingly" do
argv = CLAide::ARGV.new([])

runner = described_class.new(argv)
Expand Down
4 changes: 2 additions & 2 deletions spec/lib/danger/request_sources/github_spec.rb
Expand Up @@ -500,7 +500,7 @@
@g.update_pull_request!(warnings: [], errors: [], messages: [v])
end

it "ingores out of range inline comments when in dismiss mode" do
it "ignores out of range inline comments when in dismiss mode" do
allow(@g.client).to receive(:pull_request_comments).with("artsy/eigen", "800").and_return([])

expect(@g.client).not_to receive(:create_pull_request_comment).with("artsy/eigen", "800", anything, "561827e46167077b5e53515b4b7349b8ae04610b", "CHANGELOG.md", 10)
Expand All @@ -515,7 +515,7 @@
@g.update_pull_request!(warnings: [], errors: [], messages: [v])
end

it "ingores out of range inline comments when in dismiss mode per kind" do
it "ignores out of range inline comments when in dismiss mode per kind" do
allow(@g.client).to receive(:pull_request_comments).with("artsy/eigen", "800").and_return([])

expect(@g.client).to receive(:create_pull_request_comment).with("artsy/eigen", "800", anything, "561827e46167077b5e53515b4b7349b8ae04610b", "CHANGELOG.md", 4)
Expand Down

0 comments on commit 84f0721

Please sign in to comment.