Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add telemetry to pull, goto build page #288

Merged
merged 2 commits into from
Apr 5, 2024
Merged

feat: add telemetry to pull, goto build page #288

merged 2 commits into from
Apr 5, 2024

Commits on Apr 5, 2024

  1. feat: add telemetry to pull, goto build page 

    Exposed the telemetry logger from the extension, and changed build-disk-image.ts
to use it instead of its own. While doing this I noticed that logUsage was being
called before and after the build, so I removed the first to avoid
double-counting.

Adds telemetry event when pulling images. The intent here is to show how often
users pull the example but will also trigger when pulling the image builder
itself, which might also be useful.

Exposes telemetry logging to frontend, and sends an event when someone clicks
on the button to go to the Build page.

Part of containers#179.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    d1faedc View commit details
    Browse the repository at this point in the history

  2. chore: telemetryLogUsage and logError 

    Responding to PR review: rename API to telemetryLogUsage so that it's clear,
and expose logError() while we're at it.

Signed-off-by: Tim deBoer <git@tdeboer.ca>
    @deboer-tim
    deboer-tim committed Apr 5, 2024
    Configuration menu
    Copy the full SHA
    ef704b2 View commit details
    Browse the repository at this point in the history