feat: add telemetry to pull, goto build page #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exposed the telemetry logger from the extension, and changed build-disk-image.ts to use it instead of its own. While doing this I noticed that logUsage was being called before and after the build, so I removed the first to avoid double-counting. Adds telemetry event when pulling images. The intent here is to show how often users pull the example but will also trigger when pulling the image builder itself, which might also be useful. Exposes telemetry logging to frontend, and sends an event when someone clicks on the button to go to the Build page. Part of containers#179. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cdrage
requested changes
Apr 5, 2024
There was a problem hiding this comment.
Should we add logError as well? https://github.com/containers/podman-desktop-extension-ai-lab/blob/main/packages/shared/src/StudioAPI.ts#L58
Responding to PR review: rename API to telemetryLogUsage so that it's clear, and expose logError() while we're at it. Signed-off-by: Tim deBoer <git@tdeboer.ca>
cbr7
pushed a commit
to cbr7/podman-desktop-extension-bootc
that referenced
this pull request
Apr 11, 2024
* feat: add telemetry to pull, goto build page Exposed the telemetry logger from the extension, and changed build-disk-image.ts to use it instead of its own. While doing this I noticed that logUsage was being called before and after the build, so I removed the first to avoid double-counting. Adds telemetry event when pulling images. The intent here is to show how often users pull the example but will also trigger when pulling the image builder itself, which might also be useful. Exposes telemetry logging to frontend, and sends an event when someone clicks on the button to go to the Build page. Part of containers#179. Signed-off-by: Tim deBoer <git@tdeboer.ca> * chore: telemetryLogUsage and logError Responding to PR review: rename API to telemetryLogUsage so that it's clear, and expose logError() while we're at it. Signed-off-by: Tim deBoer <git@tdeboer.ca> --------- Signed-off-by: Tim deBoer <git@tdeboer.ca> Signed-off-by: Vladimir Lazar <vlazar@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exposed the telemetry logger from the extension, and changed build-disk-image.ts to use it instead of its own. While doing this I noticed that logUsage was being called before and after the build, so I removed the first to avoid double-counting.
Adds telemetry event when pulling images. The intent here is to show how often users pull the example but will also trigger when pulling the image builder itself, which might also be useful.
Exposes telemetry logging to frontend, and sends an event when someone clicks on the button to go to the Build page.
Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Part of #179.
How to test this PR?
Tests added to confirm telemetry events. To test manually, enable telemetry and either watch live in Segment or modify PD telemetry to output to console.