feat: Playgrounds navigation #539
Conversation
feloy
force-pushed
the
feat-525/playgrounds-list
branch
5 times, most recently
from
2cf038b
to
ffec719
Compare
feloy
force-pushed
the
feat-525/playgrounds-list
branch
3 times, most recently
from
8607d29
to
b0d193f
Compare
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
Signed-off-by: Philippe Martin <phmartin@redhat.com>
feloy
force-pushed
the
feat-525/playgrounds-list
branch
from
b0d193f
to
b8d4c88
Compare
Signed-off-by: Philippe Martin <phmartin@redhat.com>
| import { withDefaultConfiguration } from '../utils/inferenceUtils'; | ||
|
|
||
| export class PlaygroundV2Manager extends Publisher<PlaygroundV2[]> implements Disposable { | ||
| #playgrounds: Map<string, PlaygroundV2>; |
There was a problem hiding this comment.
We might prefer to add a modelId and a name to the Conversation object rather than creating a new store ?
There was a problem hiding this comment.
To simplify the review, I have superposed our 2 logics without merging them for now, it will be part of the next PR
|
|
||
| abstract createPlayground(name: string, model: ModelInfo): Promise<void>; | ||
|
|
||
| abstract getPlaygroundsV2(): Promise<PlaygroundV2[]>; |
There was a problem hiding this comment.
If we combine PlaygroundV2 and Conversation we could remove this method
|
Small hint the when the form is presented for the first time no model is selected by default the first one should be. I don't know why but this does not happen after the first playground has been created. |
Signed-off-by: Philippe Martin <phmartin@redhat.com>
should be fixed now. Thanks |
Signed-off-by: Philippe Martin <phmartin@redhat.com>
What does this PR do?
Adds a Playground page, and the possibility to create a new playground with an optional name, and a given model.
When a new playground is created and no model service is running for its model, the model server is created and started. If the model server exists but is stopped, it is started.
Out of scope for this PR:
Screenshot / video of UI
playgrounds-list.mp4
No models are downloaded yet:
More models could be downloaded:
All models are downloaded:
What issues does this PR fix or reference?
Part of #525
How to test this PR?
Go to the Playground page and use "New Playground" button to create new playgrounds.
Creating new playgrounds should start "Services" for the model chosen for the playground, if not already running
Depending on the models downloaded or not, different messages should appear (see screenhost above)