-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding new Playground Manager V2 (chat based) #504
feat: adding new Playground Manager V2 (chat based) #504
Conversation
draft until improvement |
11b74ab
to
455f43c
Compare
Will this class PlaygroundManagerV2 manage all the playgrounds (as the deprecated class I'll need to get the list of playgrounds, and add new ones in #525, should I rely on this class, or should I use/create another one? To sum up, it's not clear to me why we are creating this PlaygroundV2Manager and deprecating the PlaygroundManager, if it will cover 100% of it, when, ...? |
We have 2 concept now the inference server and the playgrounds (conversation with a model). So we have a manager for each of them |
I will create an epic |
To start working on the playgrounds list page (first part of #525), I will need to 'mock' a list of playgrounds. There is one provided by the |
This is hard to say yet ! As I mention in |
I would propose to keep the PlaygroundManager interface as it is ( It seems to me that changing to using an Inference server should be transparent as much as possible from the frontend point of view. |
@feloy IMO it does not make really much sense to keep the api Almost all the code of the current playground manager is about lifecycle of the container, which is now handled by the InferenceManager. |
455f43c
to
6eda4a1
Compare
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
390fda3
to
d1389e0
Compare
@feloy following the discussion we had this morning, I added tests ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As discussed, the interfaces will change by internalizing some values (model, etc) when we first create a Playground passing a model ID and the playground starts itself the inference server (will be part of #539)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
What does this PR do?
Introducing
PlaygroundManagerV2
which use the InferenceManager. This is specifically made for a chat base interaction with the model.New apis
getPlaygroundConversations
get the list of conversations availablecreatePlaygroundConversation
return a conversation idsubmitPlaygroundMessage
submit a message to a conversationScreenshot / video of UI
What issues does this PR fix or reference?
Fixes #509
Related to
How to test this PR?