-
Notifications
You must be signed in to change notification settings - Fork 23
Configurable batch size #389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
emasab
wants to merge
10
commits into
dev_performance_test_improvements
Choose a base branch
from
dev_fix_configurable_batch_size
base: dev_performance_test_improvements
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Configurable batch size #389
emasab
wants to merge
10
commits into
dev_performance_test_improvements
from
dev_fix_configurable_batch_size
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e881b8f
to
6900c8c
Compare
9e73424
to
ed0fb03
Compare
6900c8c
to
9b3c43a
Compare
15928f1
to
4209743
Compare
9b3c43a
to
25ec968
Compare
4209743
to
9f4461f
Compare
25ec968
to
7d20ea4
Compare
7d20ea4
to
e8bd34f
Compare
8bb5221
to
4ad7f02
Compare
rebalances in case of long processing time
f776f0c
to
0a91e33
Compare
0a91e33
to
e62aee1
Compare
92368f1
to
cfa7321
Compare
94e66ba
to
4f22357
Compare
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #286.
batch size is now configurable through the 'js.max.batch.size` property (-1 for unlimited batch size). Even when unlimited batch sizes are actually limited by librdkafka consumer buffer.
Checklist
Test & Review
automatic tests and running the performance example