Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #816 #818

Closed
wants to merge 3 commits into from
Closed

Conversation

ThomasHickman
Copy link
Member

This partially fills fills the type of parameters with type Any, so that the type can be used for bindings.

This partially fills fills the type of parameters with type Any, so that the type can be used for bindings
@mr-c
Copy link
Member

mr-c commented Jul 11, 2018

@ThomasHickman Can you share a test case that this fixes?

@codecov
Copy link

codecov bot commented Jul 11, 2018

Codecov Report

Merging #818 into master will increase coverage by 3.17%.
The diff coverage is 63.63%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #818      +/-   ##
=========================================
+ Coverage   67.12%   70.3%   +3.17%     
=========================================
  Files          30      34       +4     
  Lines        5582    6165     +583     
  Branches     1411    1570     +159     
=========================================
+ Hits         3747    4334     +587     
+ Misses       1431    1404      -27     
- Partials      404     427      +23
Impacted Files Coverage Δ
cwltool/builder.py 78.44% <63.63%> (+23.29%) ⬆️
cwltool/docker_id.py 48.97% <0%> (-2.09%) ⬇️
cwltool/executors.py 74.58% <0%> (-1.11%) ⬇️
cwltool/context.py 96.42% <0%> (-0.87%) ⬇️
cwltool/__init__.py 100% <0%> (ø)
cwltool/utils.py 47.48% <0%> (ø)
cwltool/flatten.py 78.94% <0%> (ø)
cwltool/main.py 35.78% <0%> (ø)
cwltool/load_tool.py 82.67% <0%> (+1.48%) ⬆️
cwltool/job.py 63.15% <0%> (+3.4%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d72da0...f7c360a. Read the comment docs.

@ThomasHickman
Copy link
Member Author

@mr-c mr-c changed the base branch from master to main July 2, 2020 11:11
@mr-c mr-c mentioned this pull request Sep 5, 2021
@mr-c
Copy link
Member

mr-c commented Sep 5, 2021

Moved to #1510

@mr-c mr-c closed this Sep 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants