refactor: migrate CopyableValue from MUI to Radix UI #20261
+67
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace MUI Tooltip with Radix Tooltip components and migrate Emotion CSS
to Tailwind utility classes. This is part of the ongoing effort to
standardize on Radix UI/shadcn components and Tailwind CSS.
Changes:
- Replace @mui/material/Tooltip with components/Tooltip/Tooltip (Radix)
- Remove unused PopperProps (not used anywhere in codebase)
- Rename placement prop to side to match Radix API
- Replace Emotion css={{ cursor: "pointer" }} with Tailwind cursor-pointer class
- Update single call site in IconsPage.tsx (placement → side)
- Wrap in TooltipProvider as required by Radix
Technical details:
- Radix uses Provider/Tooltip/Trigger/Content pattern (more verbose but flexible)
- Maintained backward compatibility for all other call sites (6 files)
- No functional changes to component behavior
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude <noreply@anthropic.com>
aslilac
reviewed
Oct 14, 2025
Comment on lines
+37
to
+51
| if (showCopiedSuccess !== prevCopiedRef.current) { | ||
| prevCopiedRef.current = showCopiedSuccess; | ||
|
|
||
| if (showCopiedSuccess) { | ||
| setShowCopiedText(true); | ||
| } else { | ||
| setTooltipOpen(false); | ||
| clearTimeout(timeoutRef.current); | ||
| // showCopiedText should reset after tooltip is closed to avoid a flash of the text | ||
| timeoutRef.current = window.setTimeout( | ||
| () => setShowCopiedText(false), | ||
| 100, | ||
| ); | ||
| } | ||
| } |
There was a problem hiding this comment.
if the idea is to reset things after the tooltip is hidden, this should be in an onOpenChange handler, not inline during render.
Comment on lines
+40
to
+41
| if (showCopiedSuccess) { | ||
| setShowCopiedText(true); |
There was a problem hiding this comment.
why have both showCopiedSuccess and showCopiedText? this just feels like duplicated state with messy synchronization code
| spacing={1} | ||
| justifyContent="center" | ||
| <div | ||
| css={{ marginTop: 32 }} |
There was a problem hiding this comment.
can we convert this too while we're at it?
| <Stack alignItems="center" css={{ margin: 12 }}> | ||
| <CopyableValue key={icon.url} value={icon.url}> | ||
| <div | ||
| css={{ margin: 12 }} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the
CopyableValuecomponent from Material-UI Tooltip to Radix UI Tooltip.Changes
CopyableValue Component
PopperProps(never used in any call site)placement→side(Radix naming convention)Minimal API surface change:
placementprop renamed toside(only affects 1 call site - already updated)PopperPropsremoved (was never used)