feat(scaletest): extend notifications runner with smtp support #20222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kacpersaw
force-pushed
the
kacpersaw/scaletest-notifications-smtp
branch
from
d943527 to
9411ea4
Compare
kacpersaw
force-pushed
the
kacpersaw/scaletest-smtp-mock-server
branch
from
5830a76 to
20790fc
Compare
kacpersaw
force-pushed
the
kacpersaw/scaletest-notifications-smtp
branch
3 times, most recently
from
7c9356f to
df56754
Compare
kacpersaw
force-pushed
the
kacpersaw/scaletest-notifications-smtp
branch
from
df56754 to
9bf2971
Compare
kacpersaw
force-pushed
the
kacpersaw/scaletest-notifications-smtp
branch
from
9bf2971 to
b32040f
Compare
spikecurtis
reviewed
Oct 14, 2025
kacpersaw
force-pushed
the
kacpersaw/scaletest-notifications-smtp
branch
from
c47fb2a to
a1ad593
Compare
…ter harness finishes
|
@spikecurtis also, I extracted the notifications CLI command into a separate file because it was getting too long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the scaletest notification runner with SMTP support.
If the
--smtp-api-urlflag is provided, the runner will also watch for SMTP notifications using the specified URL.Changes
notification_idandnotification_typelabelsCLI Flags
--smtp-api-url: Address of the SMTP mock HTTP API used to retrieve email notificationsMetrics
notification_delivery_latency_secondsnow includes:notification_idnotification_type(websocketorsmtp)