Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM-1324] Add logger for fallbackColor #61

Closed
wants to merge 8 commits into from

Conversation

SahilSainiYML
Copy link
Contributor

Introduction

Our Colorable protocol helps users load (and unit test) colors from asset catalogs. It provides a fallback color to use in case the named color asset cannot be found. In that case though we should log a warning message.
Extract the code that builds name from namespace + rawValue into an internal calculateName() method and cover it in unit tests.
In ColorableTests try to minimize use of logger. Ideally log only one message before disabling the logging for remainder of failure cases

Purpose

Add logger to colorable protocol and add unit test for above scenarios.

Scope

Colorable protocol and Unit test for same protocol.

📈 Coverage

Code

100%
Code coverage

Documentation

100%
Jazzy

@SahilSainiYML SahilSainiYML deleted the issue/CM-1324-LogWarningForColor branch April 11, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant